Add support for all blendmodes if we have GL_KHR_blend_equation_advanced.

gpu/command_buffer/service/feature_info.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/feature_info.h"
 
 #include <set>
 
 #include "base/command_line.h"
 #include "base/macros.h"
@@ skipping 125 matching lines @@
       ext_shader_texture_lod(false),
       use_async_readpixels(false),
       map_buffer_range(false),
       ext_discard_framebuffer(false),
       angle_depth_texture(false),
       is_angle(false),
       is_swiftshader(false),
       angle_texture_usage(false),
       ext_texture_storage(false),
       chromium_path_rendering(false),
-      ext_blend_minmax(false) {
+      ext_blend_minmax(false),
+      blend_equation_advanced(false) {
 }
 
 FeatureInfo::Workarounds::Workarounds() :
 #define GPU_OP(type, name) name(false),
     GPU_DRIVER_BUG_WORKAROUNDS(GPU_OP)
 #undef GPU_OP
     max_texture_size(0),
     max_cube_map_texture_size(0),
     max_fragment_uniform_vectors(0),
     max_varying_vectors(0),
@@ skipping 688 matching lines @@
     // DiscardFramebufferEXT is automatically bound to InvalidateFramebuffer.
     AddExtensionString("GL_EXT_discard_framebuffer");
     feature_flags_.ext_discard_framebuffer = true;
   }
 
   if (ui_gl_fence_works) {
     AddExtensionString("GL_CHROMIUM_sync_query");
     feature_flags_.chromium_sync_query = true;
   }
 
+  if (extensions.Contains("GL_NV_blend_equation_advanced") ||
+      extensions.Contains("GL_KHR_blend_equation_advanced")) {
+      const GLenum equations[] = {

[piman, 2014/10/16 20:13:29]

nit: indent looks wrong.

+          GL_MULTIPLY_NV,
+          GL_SCREEN_NV,
+          GL_OVERLAY_NV,
+          GL_DARKEN_NV,
+          GL_LIGHTEN_NV,
+          GL_COLORDODGE_NV,
+          GL_COLORBURN_NV,
+          GL_HARDLIGHT_NV,
+          GL_SOFTLIGHT_NV,
+          GL_DIFFERENCE_NV,
+          GL_EXCLUSION_NV,
+          GL_HSL_HUE_NV,
+          GL_HSL_SATURATION_NV,
+          GL_HSL_COLOR_NV,
+          GL_HSL_LUMINOSITY_NV

[piman, 2014/10/16 20:13:29]

If we don't support the whole range of enums, we shouldn't claim support for the
extension. That's also why I prefer exposing KHR_blend_equation_advanced instead
of NV_blend_equation_advanced at the command-buffer level.

[Erik Dahlström (inactive), 2014/10/17 15:33:17]

Done.

+      };
+
+      for (const GLenum& equation : equations)

[piman, 2014/10/16 20:13:29]

nit: const & superfluous?

[Erik Dahlström (inactive), 2014/10/17 15:33:17]

Done.

+          validators_.equation.AddValue(equation);
+      AddExtensionString("GL_NV_blend_equation_advanced");
+      feature_flags_.blend_equation_advanced = true;
+  }
+
   if (extensions.Contains("GL_NV_path_rendering")) {
     if (extensions.Contains("GL_EXT_direct_state_access") || is_es3) {
       AddExtensionString("GL_CHROMIUM_path_rendering");
       feature_flags_.chromium_path_rendering = true;
       validators_.g_l_state.AddValue(GL_PATH_MODELVIEW_MATRIX_CHROMIUM);
       validators_.g_l_state.AddValue(GL_PATH_PROJECTION_MATRIX_CHROMIUM);
     }
   }
 }
 
 void FeatureInfo::AddExtensionString(const char* s) {
   std::string str(s);
   size_t pos = extensions_.find(str);
   while (pos != std::string::npos &&
          pos + str.length() < extensions_.length() &&
          extensions_.substr(pos + str.length(), 1) != " ") {
     // This extension name is a substring of another.
     pos = extensions_.find(str, pos + str.length());
   }
   if (pos == std::string::npos) {
     extensions_ += (extensions_.empty() ? "" : " ") + str;
   }
 }
 
 FeatureInfo::~FeatureInfo() {
 }
 
 }  // namespace gles2
 }  // namespace gpu