Listen to the audio focus event for MSE/EME

Listen to the audio focus event for MSE/EME

For MSE/EME, we never listen to the audio focus change.
That will cause the video to continue playing when another app plays sound.
Attach MediaPlayerListener to the MediaSourcePlayer should fix the issue.

BUG=421861
Committed: https://crrev.com/68c2a8660c66d1a4e84eda6e84d0bb62bf3aa272
Cr-Commit-Position: refs/heads/master@{#299819}

[qinmin, 2014-10-10 23:50:59]

qinmin@chromium.org changed reviewers:
+ xhwang@chromium.org

[qinmin, 2014-10-10 23:50:59]

PTAL

[qinmin, 2014-10-14 17:39:28]

qinmin@chromium.org changed reviewers:
+ miguelg@chromium.org

[qinmin, 2014-10-14 17:39:29]

friendly ping

[xhwang, 2014-10-14 18:23:30]

Sorry for the delay. Some minor comments and questions.

https://codereview.chromium.org/643353002/diff/1/media/base/android/media_pla...
File media/base/android/media_player_android.h (right):

https://codereview.chromium.org/643353002/diff/1/media/base/android/media_pla...
media/base/android/media_player_android.h:104: void AttachListener(jobject
j_media_player);
It seems |j_media_player| can be NULL here. What does it mean to have a null or
non-null |j_media_player|? It's not obvious that the |j_media_player| can also
listen to those events directly. Some comments would be helpful.

https://codereview.chromium.org/643353002/diff/1/media/base/android/media_pla...
File media/base/android/media_player_bridge.cc (right):

https://codereview.chromium.org/643353002/diff/1/media/base/android/media_pla...
media/base/android/media_player_bridge.cc:105:
AttachListener(j_media_player_bridge_.obj());
Where do we detach listener?

https://codereview.chromium.org/643353002/diff/1/media/base/android/media_pla...
File media/base/android/media_player_listener.cc (right):

https://codereview.chromium.org/643353002/diff/1/media/base/android/media_pla...
media/base/android/media_player_listener.cc:36: if
(j_media_player_listener_.is_null()) {
In which circumstance we could create the listener more than once?

https://codereview.chromium.org/643353002/diff/1/media/base/android/media_pla...
File media/base/android/media_player_listener.h (right):

https://codereview.chromium.org/643353002/diff/1/media/base/android/media_pla...
media/base/android/media_player_listener.h:58: // The MediaPlayerAndroid object
all the callbacks should be send to.
s/send/sent

[qinmin, 2014-10-14 21:55:51]

https://codereview.chromium.org/643353002/diff/1/media/base/android/media_pla...
File media/base/android/media_player_android.h (right):

https://codereview.chromium.org/643353002/diff/1/media/base/android/media_pla...
media/base/android/media_player_android.h:104: void AttachListener(jobject
j_media_player);
On 2014/10/14 18:23:30, xhwang wrote:
> It seems |j_media_player| can be NULL here. What does it mean to have a null
or
> non-null |j_media_player|? It's not obvious that the |j_media_player| can also
> listen to those events directly. Some comments would be helpful.

Done.

https://codereview.chromium.org/643353002/diff/1/media/base/android/media_pla...
File media/base/android/media_player_bridge.cc (right):

https://codereview.chromium.org/643353002/diff/1/media/base/android/media_pla...
media/base/android/media_player_bridge.cc:105:
AttachListener(j_media_player_bridge_.obj());
On 2014/10/14 18:23:30, xhwang wrote:
> Where do we detach listener?

good catch, should be in release() call. Fixed.

https://codereview.chromium.org/643353002/diff/1/media/base/android/media_pla...
File media/base/android/media_player_listener.cc (right):

https://codereview.chromium.org/643353002/diff/1/media/base/android/media_pla...
media/base/android/media_player_listener.cc:36: if
(j_media_player_listener_.is_null()) {
On 2014/10/14 18:23:30, xhwang wrote:
> In which circumstance we could create the listener more than once?

MediaPlayerAndroid::DetachListener() could release the java object. So we may
need to recreate it in the AttachListener() call.

https://codereview.chromium.org/643353002/diff/1/media/base/android/media_pla...
File media/base/android/media_player_listener.h (right):

https://codereview.chromium.org/643353002/diff/1/media/base/android/media_pla...
media/base/android/media_player_listener.h:58: // The MediaPlayerAndroid object
all the callbacks should be send to.
On 2014/10/14 18:23:30, xhwang wrote:
> s/send/sent

Done.

[xhwang, 2014-10-15 16:51:36]

lgtm

[qinmin, 2014-10-15 18:34:20]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2014-10-15 18:35:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/643353002/120001

[commit-bot: I haz the power, 2014-10-15 18:39:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-15 18:39:13]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/69004)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[qinmin, 2014-10-16 00:44:33]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2014-10-16 00:46:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/643353002/140001

[commit-bot: I haz the power, 2014-10-16 02:08:50]

Committed patchset #3 (id:140001)

[commit-bot: I haz the power, 2014-10-16 02:09:36]

Patchset 3 (id:??) landed as
https://crrev.com/68c2a8660c66d1a4e84eda6e84d0bb62bf3aa272
Cr-Commit-Position: refs/heads/master@{#299819}