content/browser/media/media_internals_proxy.cc - Issue 643343004: Video Capture Capabilities available on chrome://media-internals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/media_internals_proxy.cc

Issue 643343004: Video Capture Capabilities available on chrome://media-internals (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/media/media_internals.cc ('K') | « content/browser/media/media_internals.cc ('k') | content/browser/media/media_internals_unittest.cc » ('j') | content/browser/resources/media/client_renderer.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/media/media_internals_proxy.cc

diff --git a/content/browser/media/media_internals_proxy.cc b/content/browser/media/media_internals_proxy.cc

index 3190884ef38821ef6b9f2aeeef0611f58ab30bed..25e5c507ab1cee60834d644b111d700bc6da1572 100644

--- a/content/browser/media/media_internals_proxy.cc

+++ b/content/browser/media/media_internals_proxy.cc

@@ -138,7 +138,7 @@ void MediaInternalsProxy::StopObservingMediaInternalsOnIOThread() {

void MediaInternalsProxy::GetEverythingOnIOThread() {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

MediaInternals::GetInstance()->SendAudioStreamData();

- // TODO(mcasas): Collect capabilities of Video Capture devices.

+ MediaInternals::GetInstance()->SendVideoCaptureCapabilities();

perkj_chrome 2014/10/15 15:05:16 This is on IO.

burnik 2014/10/15 15:43:13 Done.

}

void MediaInternalsProxy::UpdateUIOnUIThread(const base::string16& update) {