Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: src/hydrogen-instructions.h

Issue 64333002: Revert "Add new HSeqStringGetChar instruction." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen-instructions.h
diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h
index 15f307783b90718525ddd747f6a1d41fd0a30611..66050f1398c1da307365f11854be912f3a39afc3 100644
--- a/src/hydrogen-instructions.h
+++ b/src/hydrogen-instructions.h
@@ -159,7 +159,6 @@ class LChunkBuilder;
V(Return) \
V(Ror) \
V(Sar) \
- V(SeqStringGetChar) \
V(SeqStringSetChar) \
V(Shl) \
V(Shr) \
@@ -7024,56 +7023,6 @@ class HDateField V8_FINAL : public HUnaryOperation {
};
-class HSeqStringGetChar V8_FINAL : public HTemplateInstruction<2> {
- public:
- static HInstruction* New(Zone* zone,
- HValue* context,
- String::Encoding encoding,
- HValue* string,
- HValue* index);
-
- virtual Representation RequiredInputRepresentation(int index) V8_OVERRIDE {
- return (index == 0) ? Representation::Tagged()
- : Representation::Integer32();
- }
-
- String::Encoding encoding() const { return encoding_; }
- HValue* string() const { return OperandAt(0); }
- HValue* index() const { return OperandAt(1); }
-
- DECLARE_CONCRETE_INSTRUCTION(SeqStringGetChar)
-
- protected:
- virtual bool DataEquals(HValue* other) V8_OVERRIDE {
- return encoding() == HSeqStringGetChar::cast(other)->encoding();
- }
-
- virtual Range* InferRange(Zone* zone) V8_OVERRIDE {
- if (encoding() == String::ONE_BYTE_ENCODING) {
- return new(zone) Range(0, String::kMaxOneByteCharCode);
- } else {
- ASSERT_EQ(String::TWO_BYTE_ENCODING, encoding());
- return new(zone) Range(0, String::kMaxUtf16CodeUnit);
- }
- }
-
- private:
- HSeqStringGetChar(String::Encoding encoding,
- HValue* string,
- HValue* index) : encoding_(encoding) {
- SetOperandAt(0, string);
- SetOperandAt(1, index);
- set_representation(Representation::Integer32());
- SetFlag(kUseGVN);
- SetGVNFlag(kDependsOnStringChars);
- }
-
- virtual bool IsDeletable() const V8_OVERRIDE { return true; }
-
- String::Encoding encoding_;
-};
-
-
class HSeqStringSetChar V8_FINAL : public HTemplateInstruction<3> {
public:
DECLARE_INSTRUCTION_FACTORY_P4(HSeqStringSetChar, String::Encoding,
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698