Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 64333002: Revert "Add new HSeqStringGetChar instruction." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-ia32.h ('k') | src/x64/assembler-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1855 matching lines...) Expand 10 before | Expand all | Expand 10 after
1866 1866
1867 1867
1868 LInstruction* LChunkBuilder::DoDateField(HDateField* instr) { 1868 LInstruction* LChunkBuilder::DoDateField(HDateField* instr) {
1869 LOperand* date = UseFixed(instr->value(), eax); 1869 LOperand* date = UseFixed(instr->value(), eax);
1870 LDateField* result = 1870 LDateField* result =
1871 new(zone()) LDateField(date, FixedTemp(ecx), instr->index()); 1871 new(zone()) LDateField(date, FixedTemp(ecx), instr->index());
1872 return MarkAsCall(DefineFixed(result, eax), instr, CAN_DEOPTIMIZE_EAGERLY); 1872 return MarkAsCall(DefineFixed(result, eax), instr, CAN_DEOPTIMIZE_EAGERLY);
1873 } 1873 }
1874 1874
1875 1875
1876 LInstruction* LChunkBuilder::DoSeqStringGetChar(HSeqStringGetChar* instr) {
1877 LOperand* string = UseRegisterAtStart(instr->string());
1878 LOperand* index = UseRegisterOrConstantAtStart(instr->index());
1879 return DefineAsRegister(new(zone()) LSeqStringGetChar(string, index));
1880 }
1881
1882
1883 LInstruction* LChunkBuilder::DoSeqStringSetChar(HSeqStringSetChar* instr) { 1876 LInstruction* LChunkBuilder::DoSeqStringSetChar(HSeqStringSetChar* instr) {
1884 LOperand* string = UseRegisterAtStart(instr->string()); 1877 LOperand* string = UseRegisterAtStart(instr->string());
1885 LOperand* index = UseRegisterOrConstantAtStart(instr->index()); 1878 LOperand* index = UseRegisterOrConstantAtStart(instr->index());
1886 LOperand* value = (instr->encoding() == String::ONE_BYTE_ENCODING) 1879 LOperand* value = (instr->encoding() == String::ONE_BYTE_ENCODING)
1887 ? UseFixedOrConstant(instr->value(), eax) 1880 ? UseFixedOrConstant(instr->value(), eax)
1888 : UseRegisterOrConstantAtStart(instr->value()); 1881 : UseRegisterOrConstantAtStart(instr->value());
1889 return new(zone()) LSeqStringSetChar(string, index, value); 1882 return new(zone()) LSeqStringSetChar(string, index, value);
1890 } 1883 }
1891 1884
1892 1885
(...skipping 857 matching lines...) Expand 10 before | Expand all | Expand 10 after
2750 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2743 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2751 LOperand* object = UseRegister(instr->object()); 2744 LOperand* object = UseRegister(instr->object());
2752 LOperand* index = UseTempRegister(instr->index()); 2745 LOperand* index = UseTempRegister(instr->index());
2753 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2746 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2754 } 2747 }
2755 2748
2756 2749
2757 } } // namespace v8::internal 2750 } } // namespace v8::internal
2758 2751
2759 #endif // V8_TARGET_ARCH_IA32 2752 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/lithium-ia32.h ('k') | src/x64/assembler-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698