Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: mojo/public/tools/bindings/generators/mojom_js_generator.py

Issue 643323002: [Mojo] Add support for HTML imports as well as AMD modules (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/tools/bindings/generators/mojom_js_generator.py
diff --git a/mojo/public/tools/bindings/generators/mojom_js_generator.py b/mojo/public/tools/bindings/generators/mojom_js_generator.py
index c9109fbbec3694462a22ed78f8efccdcd2b08c11..dcce387bbd867a09e5a83784ca260c3f6721a2bd 100644
--- a/mojo/public/tools/bindings/generators/mojom_js_generator.py
+++ b/mojo/public/tools/bindings/generators/mojom_js_generator.py
@@ -250,8 +250,7 @@ class Generator(generator.Generator):
"validate_struct_params": JavaScriptValidateStructParams,
}
- @UseJinja("js_templates/module.js.tmpl", filters=js_filters)
- def GenerateJsModule(self):
+ def GetParameters(self):
return {
"namespace": self.module.namespace,
"imports": self.GetImports(),
@@ -262,8 +261,17 @@ class Generator(generator.Generator):
"interfaces": self.module.interfaces,
}
+ @UseJinja("js_templates/module.amd.tmpl", filters=js_filters)
+ def GenerateAMDModule(self):
+ return self.GetParameters()
+
+ @UseJinja("js_templates/module.html.tmpl", filters=js_filters)
+ def GenerateHTMLModule(self):
+ return self.GetParameters()
+
def GenerateFiles(self, args):
- self.Write(self.GenerateJsModule(), "%s.js" % self.module.name)
+ self.Write(self.GenerateAMDModule(), "%s.js" % self.module.name)
+ self.Write(self.GenerateHTMLModule(), "%s.html" % self.module.name)
def GetImports(self):
# Since each import is assigned a variable in JS, they need to have unique

Powered by Google App Engine
This is Rietveld 408576698