Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 643323002: [Mojo] Add support for HTML imports as well as AMD modules (Closed)

Created:
6 years, 2 months ago by abarth-chromium
Modified:
6 years, 2 months ago
Reviewers:
hansmuller
CC:
Aaron Boodman, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Mojo] Add support for HTML imports as well as AMD modules This CL teaches the mojom generator how to package JavaScript generated from mojom both as AMD modules as an HTML imports. R=hansmuller@chromium.org Committed: https://crrev.com/d1045a6133a372e40638457a5ab5189e139f07d5 Cr-Commit-Position: refs/heads/master@{#299310}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : Fix indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -84 lines) Patch
A mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
A mojo/public/tools/bindings/generators/js_templates/module.html.tmpl View 1 chunk +13 lines, -0 lines 0 comments Download
D mojo/public/tools/bindings/generators/js_templates/module.js.tmpl View 1 1 chunk +0 lines, -59 lines 0 comments Download
A + mojo/public/tools/bindings/generators/js_templates/module_definition.tmpl View 1 2 chunks +1 line, -20 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_js_generator.py View 1 2 chunks +11 lines, -3 lines 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom_bindings_generator.gypi View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (1 generated)
abarth-chromium
6 years, 2 months ago (2014-10-10 21:46:25 UTC) #1
hansmuller
The delegating stub CL just landed - https://codereview.chromium.org/637373002/. The module template definitions will need to ...
6 years, 2 months ago (2014-10-10 22:12:55 UTC) #2
abarth-chromium
On 2014/10/10 at 22:12:55, hansmuller wrote: > The delegating stub CL just landed - https://codereview.chromium.org/637373002/. ...
6 years, 2 months ago (2014-10-10 22:30:30 UTC) #3
hansmuller
Eventually we're going to need to a better scheme for naming modules. A developer trying ...
6 years, 2 months ago (2014-10-10 22:55:31 UTC) #4
abarth-chromium
https://codereview.chromium.org/643323002/diff/1/mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl File mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl (right): https://codereview.chromium.org/643323002/diff/1/mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl#newcode11 mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl:11: ], function(codec, validator On 2014/10/10 at 22:55:31, hansmuller wrote: ...
6 years, 2 months ago (2014-10-10 22:57:55 UTC) #5
abarth-chromium
On 2014/10/10 at 22:55:31, hansmuller wrote: > Eventually we're going to need to a better ...
6 years, 2 months ago (2014-10-10 22:58:30 UTC) #6
abarth-chromium
@hansmuller: Ping?
6 years, 2 months ago (2014-10-13 16:11:26 UTC) #7
hansmuller
On 2014/10/13 16:11:26, abarth wrote: > @hansmuller: Ping? This patch LGTM.
6 years, 2 months ago (2014-10-13 16:34:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643323002/300001
6 years, 2 months ago (2014-10-13 16:39:38 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:300001)
6 years, 2 months ago (2014-10-13 17:02:33 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 17:03:25 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d1045a6133a372e40638457a5ab5189e139f07d5
Cr-Commit-Position: refs/heads/master@{#299310}

Powered by Google App Engine
This is Rietveld 408576698