net/quic/quic_received_packet_manager_test.cc - Issue 643313003: Fix a bug where packet received times aren't sent if the approximate now

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_received_packet_manager_test.cc

Issue 643313003: Fix a bug where packet received times aren't sent if the approximate now (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Change_the_pacing_sender_77004656

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_received_packet_manager_test.cc

diff --git a/net/quic/quic_received_packet_manager_test.cc b/net/quic/quic_received_packet_manager_test.cc

index 9e8c1281942832a628aad822c1274e6c8ad52603..396c8ee90a1707618cbe1b5b4cb299898a1cbc9d 100644

--- a/net/quic/quic_received_packet_manager_test.cc

+++ b/net/quic/quic_received_packet_manager_test.cc

@@ -314,6 +314,7 @@ TEST_F(QuicReceivedPacketManagerTest, UpdateReceivedPacketInfo) {

// When UpdateReceivedPacketInfo with a time earlier than the time of the

// largest observed packet, make sure that the delta is 0, not negative.

EXPECT_EQ(QuicTime::Delta::Zero(), ack.delta_time_largest_observed);

+ EXPECT_FALSE(ack.received_packet_times.empty());

QuicTime four_ms = QuicTime::Zero().Add(QuicTime::Delta::FromMilliseconds(4));

received_manager_.UpdateReceivedPacketInfo(&ack, four_ms);

« no previous file with comments | « net/quic/quic_received_packet_manager.cc ('k') | no next file » | no next file with comments »