Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 643273002: telemetry: Remove 7 obsolete rendering benchmarks. (Closed)

Created:
6 years, 2 months ago by ernstm
Modified:
6 years, 2 months ago
Reviewers:
tonyg, dtu, nduca
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

telemetry: Remove 7 obsolete rendering benchmarks. R=tonyg@chromium.org,nduca@chromium.org BUG= Committed: https://crrev.com/62ea8e6bf330e36bc9a72340f05878b174869b03 Cr-Commit-Position: refs/heads/master@{#299220}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add repaint.key_mobile_sites back. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -96 lines) Patch
M tools/perf/benchmarks/rasterize_and_record_micro.py View 2 chunks +0 lines, -17 lines 0 comments Download
M tools/perf/benchmarks/silk_flags.py View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/perf/benchmarks/smoothness.py View 5 chunks +1 line, -64 lines 0 comments Download
M tools/perf/benchmarks/thread_times.py View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
ernstm
PTAL
6 years, 2 months ago (2014-10-10 20:28:42 UTC) #1
dtu
lgtm
6 years, 2 months ago (2014-10-10 21:17:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643273002/1
6 years, 2 months ago (2014-10-10 21:19:03 UTC) #5
tonyg
https://codereview.chromium.org/643273002/diff/1/tools/perf/benchmarks/repaint.py File tools/perf/benchmarks/repaint.py (left): https://codereview.chromium.org/643273002/diff/1/tools/perf/benchmarks/repaint.py#oldcode12 tools/perf/benchmarks/repaint.py:12: class RepaintKeyMobileSites(benchmark.Benchmark): lgtm modulo our discussion about this one.
6 years, 2 months ago (2014-10-10 21:24:03 UTC) #6
ernstm
https://codereview.chromium.org/643273002/diff/1/tools/perf/benchmarks/repaint.py File tools/perf/benchmarks/repaint.py (left): https://codereview.chromium.org/643273002/diff/1/tools/perf/benchmarks/repaint.py#oldcode12 tools/perf/benchmarks/repaint.py:12: class RepaintKeyMobileSites(benchmark.Benchmark): On 2014/10/10 21:24:03, tonyg wrote: > lgtm ...
6 years, 2 months ago (2014-10-10 21:54:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643273002/220001
6 years, 2 months ago (2014-10-10 21:55:30 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:220001)
6 years, 2 months ago (2014-10-11 00:32:03 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-11 00:32:43 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/62ea8e6bf330e36bc9a72340f05878b174869b03
Cr-Commit-Position: refs/heads/master@{#299220}

Powered by Google App Engine
This is Rietveld 408576698