Fixes device/bluetooth / chromeos dependencies for GN.

device/bluetooth/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//tools/grit/grit_rule.gni")
 
 config("bluetooth_config") {
   if (is_win) {
     ldflags = [
       # Despite MSDN stating that Bthprops.dll contains the
@@ skipping 83 matching lines @@
   all_dependent_configs = [ ":bluetooth_config" ]
 
   deps = [
     ":strings",
     "//base",
     "//net",
     "//ui/base",
   ]
 
   if (is_chromeos) {
-    deps += [
-      "//chromeos",
-      "//dbus",
-    ]
+    public_deps = [ "//chromeos" ]

[Ilya Sherman, 2014/10/13 22:00:23]

//device/bluetooth still has a direct dependency on //dbus, right? 
Stylistically, is it appropriate to pull that in implicitly via //chromeos's
public deps, or should it be respecified as a private dependency for this code?

[Jun Mukai, 2014/10/13 22:17:09]

You're right.  It was added implicitly through //chromeos. However some
bluetooth (for ChromeOS) files actually refers to some //dbus files, it's better
to have dependency of //dbus explicitly.

I am not so sure which is better for this case. But some header file (like
bluetooth_device_chromeos.h) actually includes files like "dbus/object_path.h",
so having as public_deps would be better at least for now.

Once the dependency and EXPORT things are cleaned up, I hope this can be
reverted back to normal deps.

   }
 
   if (is_mac) {
     libs = [ "IOBluetooth.framework" ]
   }
 }
 
 grit("strings") {
   source = "bluetooth_strings.grd"
   outputs = [
@@ skipping 76 matching lines @@
     "test/mock_bluetooth_gatt_service.h",
     "test/mock_bluetooth_socket.cc",
     "test/mock_bluetooth_socket.h",
   ]
 
   deps = [
     ":bluetooth",
     "//testing/gmock",
   ]
 }