Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 64323002: Minor optimization in FrameSelection::setNonDirectionalSelectionIfNeeded(). (Closed)

Created:
7 years, 1 month ago by arpitab_
Modified:
7 years, 1 month ago
Reviewers:
ojan, yosin_UTC9, eseidel
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Minor optimization in FrameSelection::setNonDirectionalSelectionIfNeeded(). We can avoid a second call to newSelection.visibleExtent() by maintaining a local variable for the same. A call to visibleExtent() further entails computing of VisiblePosition which can be avoided the second time round. This change also makes it similar to the handling of newSelection.visibleBase(). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161602

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M Source/core/editing/FrameSelection.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
arpitab_
7 years, 1 month ago (2013-11-07 13:04:49 UTC) #1
yosin_UTC9
ACK
7 years, 1 month ago (2013-11-08 01:16:07 UTC) #2
eseidel
lgtm
7 years, 1 month ago (2013-11-08 01:50:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a.bah@samsung.com/64323002/1
7 years, 1 month ago (2013-11-08 01:50:27 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) weborigin_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=11606
7 years, 1 month ago (2013-11-08 03:06:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a.bah@samsung.com/64323002/1
7 years, 1 month ago (2013-11-08 05:48:57 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) weborigin_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=11683
7 years, 1 month ago (2013-11-08 06:52:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a.bah@samsung.com/64323002/1
7 years, 1 month ago (2013-11-08 08:32:18 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) weborigin_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=11767
7 years, 1 month ago (2013-11-08 09:34:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a.bah@samsung.com/64323002/1
7 years, 1 month ago (2013-11-08 09:58:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a.bah@samsung.com/64323002/1
7 years, 1 month ago (2013-11-08 10:03:37 UTC) #11
commit-bot: I haz the power
7 years, 1 month ago (2013-11-08 10:16:52 UTC) #12
Message was sent while issue was closed.
Change committed as 161602

Powered by Google App Engine
This is Rietveld 408576698