Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Issue 643213002: Update constants to MACRO_STYLE (Closed)

Created:
6 years, 2 months ago by Marie Janssen
Modified:
6 years, 2 months ago
Reviewers:
keybuk, armansito
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update constants to MACRO_STYLE BUG=418696 Committed: https://crrev.com/bc2ad7606ae6fcd2d83f30154ea623cedc747cfc Cr-Commit-Position: refs/heads/master@{#299349}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -82 lines) Patch
M device/bluetooth/bluetooth_gatt_characteristic.h View 3 chunks +21 lines, -21 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_chromeos_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_characteristic_chromeos.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_descriptor_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc View 6 chunks +34 lines, -34 lines 0 comments Download
M extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc View 1 chunk +12 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Marie Janssen
Update to MACRO_STYLE as recommended by developers/coding-style
6 years, 2 months ago (2014-10-10 17:52:39 UTC) #2
armansito
lgtm and thanks for the clean up!
6 years, 2 months ago (2014-10-13 18:47:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643213002/1
6 years, 2 months ago (2014-10-13 18:49:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-13 19:51:36 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 19:52:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc2ad7606ae6fcd2d83f30154ea623cedc747cfc
Cr-Commit-Position: refs/heads/master@{#299349}

Powered by Google App Engine
This is Rietveld 408576698