Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 643193002: Disable implicit conversions from scoped_refptr to T* on iOS. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
danakj
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org, rohitrao (ping after 24h), stuartmorgan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable implicit conversions from scoped_refptr to T* on iOS. BUG=110610 Committed: https://crrev.com/ad794d3c472690a8f9ac1772b56829185c177d00 Cr-Commit-Position: refs/heads/master@{#299238}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/memory/ref_counted.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
This is blocked on two internal-only patches, but I found no public code that needed ...
6 years, 2 months ago (2014-10-10 17:11:48 UTC) #2
danakj
LGTM
6 years, 2 months ago (2014-10-10 17:15:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643193002/1
6 years, 2 months ago (2014-10-11 03:34:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/23132)
6 years, 2 months ago (2014-10-11 05:13:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643193002/1
6 years, 2 months ago (2014-10-11 05:26:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-11 06:55:28 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-11 06:56:16 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad794d3c472690a8f9ac1772b56829185c177d00
Cr-Commit-Position: refs/heads/master@{#299238}

Powered by Google App Engine
This is Rietveld 408576698