add imported inherited member suggestions

pkg/analysis_server/lib/src/services/completion/local_computer.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.computer.dart.local;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/protocol.dart' as protocol show Element,
     ElementKind;
 import 'package:analysis_server/src/protocol.dart' hide Element, ElementKind;
 import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';
+import 'package:analysis_server/src/services/completion/suggestion_builder.dart';
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/scanner.dart';
 
 /**
  * A computer for calculating `completion.getSuggestions` request results
  * for the local library in which the completion is requested.
  */
 class LocalComputer extends DartCompletionComputer {
 
   @override
@@ skipping 74 matching lines @@
   @override
   visitCatchClause(CatchClause node) {
     _addParamSuggestion(node.exceptionParameter, node.exceptionType);
     _addParamSuggestion(node.stackTraceParameter, STACKTRACE_TYPE);
     visitNode(node);
   }
 
   @override
   visitClassDeclaration(ClassDeclaration node) {
     _addClassDeclarationMembers(node);
-    _addInheritedTypeMembers(node);
+    visitInheritedTypes(node, (ClassDeclaration classNode) {
+      _addClassDeclarationMembers(classNode);
+    }, (String typeName) {
+      // ignored
+    });
     visitNode(node);
   }
 
-  void _addInheritedTypeMembers(ClassDeclaration node) {
-    ExtendsClause extendsClause = node.extendsClause;
-    if (extendsClause != null) {
-      _addLocalTypeMembers(extendsClause.superclass, node);
-    }
-    ImplementsClause implementsClause = node.implementsClause;
-    if (implementsClause != null) {
-      NodeList<TypeName> interfaces = implementsClause.interfaces;
-      if (interfaces != null) {
-        interfaces.forEach((TypeName type) {
-          _addLocalTypeMembers(type, node);
-        });
-      }
-    }
-    WithClause withClause = node.withClause;
-    if (withClause != null) {
-      NodeList<TypeName> mixinTypes = withClause.mixinTypes;
-      if (mixinTypes != null) {
-        mixinTypes.forEach((TypeName type) {
-          _addLocalTypeMembers(type, node);
-        });
-      }
-    }
-  }
-
-  void _addLocalTypeMembers(TypeName type, ClassDeclaration node) {
-    if (type == null) {
-      return;
-    }
-    Identifier typeId = type.name;
-    if (typeId == null) {
-      return;
-    }
-    String typeName = typeId.name;
-    if (typeName == null || typeName.length == 0) {
-      return;
-    }
-    CompilationUnit unit = node.getAncestor((p) => p is CompilationUnit);
-    if (unit == null) {
-      return;
-    }
-    unit.declarations.forEach((CompilationUnitMember m) {
-      if (m is ClassDeclaration) {
-        SimpleIdentifier id = m.name;
-        if (id != null) {
-          if (id.name == typeName) {
-            _addClassDeclarationMembers(m);
-            _addInheritedTypeMembers(m);
-          }
-        }
-      }
-    });
-  }
-
-  void _addClassDeclarationMembers(ClassDeclaration node) {
-    node.members.forEach((ClassMember classMbr) {
-      if (classMbr is FieldDeclaration) {
-        _addFieldSuggestions(node, classMbr);
-      } else if (classMbr is MethodDeclaration) {
-        _addMethodSuggestion(node, classMbr);
-      }
-    });
-  }
-
   @override
   visitCombinator(Combinator node) {
     // Handled by ImportedComputer
   }
 
   @override
   visitCompilationUnit(CompilationUnit node) {
     node.declarations.forEach((Declaration declaration) {
       if (declaration is ClassDeclaration) {
         _addClassSuggestion(declaration);
@@ skipping 130 matching lines @@
   visitVariableDeclaration(VariableDeclaration node) {
     // Do not add suggestions if editing the name in a var declaration
     SimpleIdentifier name = node.name;
     if (name == null ||
         name.offset < request.offset ||
         request.offset > name.end) {
       visitNode(node);
     }
   }
 
+  void _addClassDeclarationMembers(ClassDeclaration node) {
+    node.members.forEach((ClassMember classMbr) {
+      if (classMbr is FieldDeclaration) {
+        _addFieldSuggestions(node, classMbr);
+      } else if (classMbr is MethodDeclaration) {
+        _addMethodSuggestion(node, classMbr);
+      }
+    });
+  }
+
   void _addClassSuggestion(ClassDeclaration declaration) {
     CompletionSuggestion suggestion =
         _addSuggestion(declaration.name, CompletionSuggestionKind.CLASS, null, null);
     if (suggestion != null) {
       suggestion.element = _createElement(
           protocol.ElementKind.CLASS,
           declaration.name,
           NO_RETURN_TYPE,
           declaration.isAbstract,
           _isDeprecated(declaration.metadata));
@@ skipping 225 matching lines @@
     if (name == null || name.length <= 0) {
       return DYNAMIC;
     }
     TypeArgumentList typeArgs = type.typeArguments;
     if (typeArgs != null) {
       //TODO (danrubel) include type arguments
     }
     return name;
   }
 }