Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 643143005: Fix {get,set}ter-on-elements tests to run through all creation functions (Closed)

Created:
6 years, 2 months ago by adamk
Modified:
6 years, 2 months ago
Reviewers:
mvstanton
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix {get,set}ter-on-elements tests to run through all creation functions setter-on-elements had the wrong length hardcoded in a for loop over the creation functions (getter-on-elements had the right length, but seemed worth future-proofing). R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24813

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M test/mjsunit/getters-on-elements.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/setters-on-elements.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
adamk
Found these while poking at the prototype performance bug.
6 years, 2 months ago (2014-10-21 18:52:40 UTC) #2
mvstanton
right on, LGTM.
6 years, 2 months ago (2014-10-22 08:15:16 UTC) #3
adamk
6 years, 2 months ago (2014-10-22 17:21:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24813 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698