src/x64/stub-cache-x64.cc - Issue 64313002: Introduce MoveInteger64 instruction into X64 Macro Assembler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/stub-cache-x64.cc

Issue 64313002: Introduce MoveInteger64 instruction into X64 Macro Assembler (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Refine a comment Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/stub-cache-x64.cc

diff --git a/src/x64/stub-cache-x64.cc b/src/x64/stub-cache-x64.cc

index 499ccdf24caeadb9b648cf5a846633241de815e6..3a0db8fdbb3380737905ee27ef991e22ec166a86 100644

--- a/src/x64/stub-cache-x64.cc

+++ b/src/x64/stub-cache-x64.cc

@@ -2293,7 +2293,7 @@ Handle<Code> CallStubCompiler::CompileMathFloorCall(

Label already_round;

__ bind(&conversion_failure);

int64_t kTwoMantissaBits= V8_INT64_C(0x4330000000000000);

- __ movq(rbx, kTwoMantissaBits);

+ __ MoveInteger64(rbx, kTwoMantissaBits);

__ movq(xmm1, rbx);

__ ucomisd(xmm0, xmm1);

__ j(above_equal, &already_round);

@@ -2314,7 +2314,7 @@ Handle<Code> CallStubCompiler::CompileMathFloorCall(

// Subtract 1 if the argument was less than the tentative result.

int64_t kOne = V8_INT64_C(0x3ff0000000000000);

- __ movq(rbx, kOne);

+ __ MoveInteger64(rbx, kOne);

__ movq(xmm1, rbx);

__ andpd(xmm1, xmm2);

__ subsd(xmm0, xmm1);

« no previous file with comments | « src/x64/macro-assembler-x64.cc ('k') | no next file » | no next file with comments »