Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 643123002: Roll libyuv 455c66b:9107460 (Closed)

Created:
6 years, 2 months ago by gordanac
Modified:
6 years, 2 months ago
Reviewers:
fbarchard, amineer_google, Ben Murdoch, fbarchard1, gordana.cmiljanovic, dxie1, amineer
CC:
chromium-reviews, petar.jovanovic, Paul Lind
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Roll libyuv 455c66b:9107460 (libyuv r1125) BUG=400684 Committed: https://crrev.com/20429ab66f5eee7af8df407bb2cab4af624f650b Cr-Commit-Position: refs/heads/master@{#300098}

Patch Set 1 #

Patch Set 2 : Roll to f6e4951 #

Patch Set 3 : Roll to 9107460 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 38 (14 generated)
gordanac
PTAL
6 years, 2 months ago (2014-10-10 14:51:50 UTC) #2
gordanac
This is continued from: https://codereview.chromium.org/544253002/
6 years, 2 months ago (2014-10-10 18:40:55 UTC) #3
gordanac
Updated to r1120. Please take a look.
6 years, 2 months ago (2014-10-15 10:57:42 UTC) #5
amineer_google
On 2014/10/15 10:57:42, gordanac wrote: > Updated to r1120. > Please take a look. lgtm
6 years, 2 months ago (2014-10-15 17:07:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643123002/50001
6 years, 2 months ago (2014-10-15 17:16:13 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-10-15 17:16:16 UTC) #10
amineer
On 2014/10/15 17:16:16, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 2 months ago (2014-10-15 18:27:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643123002/50001
6 years, 2 months ago (2014-10-15 19:05:17 UTC) #13
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-10-15 19:05:20 UTC) #15
dxie1
lgtm
6 years, 2 months ago (2014-10-15 22:56:11 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643123002/50001
6 years, 2 months ago (2014-10-15 23:25:10 UTC) #19
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-10-15 23:25:15 UTC) #21
fbarchard
Do try bots pass?
6 years, 2 months ago (2014-10-16 01:12:49 UTC) #22
fbarchard
lgtm Looking thru the revisions http://git.chromium.org/gitweb/?p=external/libyuv.git;a=summary this is the head code revision, which is 1120, ...
6 years, 2 months ago (2014-10-16 02:15:48 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643123002/50001
6 years, 2 months ago (2014-10-16 02:19:22 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/22629)
6 years, 2 months ago (2014-10-16 04:21:47 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643123002/50001
6 years, 2 months ago (2014-10-16 08:25:18 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_swarming/builds/19666)
6 years, 2 months ago (2014-10-16 10:28:20 UTC) #31
Ben Murdoch
On 2014/10/16 10:28:20, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 2 months ago (2014-10-16 10:30:50 UTC) #32
chromium-reviews
ya, I think I see the problem... unaligned memory. filed bug, fix coming. Could also ...
6 years, 2 months ago (2014-10-16 23:33:18 UTC) #33
gordanac
Giving a try to r1125 (https://chromium.googlesource.com/external/libyuv/+/9107460c7f76a10cc4122d91e62b0580eacd376e)
6 years, 2 months ago (2014-10-17 12:24:31 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643123002/70001
6 years, 2 months ago (2014-10-17 12:25:22 UTC) #36
commit-bot: I haz the power
Committed patchset #3 (id:70001)
6 years, 2 months ago (2014-10-17 13:34:30 UTC) #37
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 13:35:38 UTC) #38
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/20429ab66f5eee7af8df407bb2cab4af624f650b
Cr-Commit-Position: refs/heads/master@{#300098}

Powered by Google App Engine
This is Rietveld 408576698