|
|
DescriptionRoll libyuv 455c66b:9107460
(libyuv r1125)
BUG=400684
Committed: https://crrev.com/20429ab66f5eee7af8df407bb2cab4af624f650b
Cr-Commit-Position: refs/heads/master@{#300098}
Patch Set 1 #Patch Set 2 : Roll to f6e4951 #Patch Set 3 : Roll to 9107460 #Messages
Total messages: 38 (14 generated)
gordana.cmiljanovic@imgtec.com changed reviewers: + benm@google.com, fbarchard@chromium.org, fbarchard@google.com
PTAL
This is continued from: https://codereview.chromium.org/544253002/
gordana.cmiljanovic@imgtec.com changed reviewers: + amineer@chromium.org, amineer@google.com
Updated to r1120. Please take a look.
On 2014/10/15 10:57:42, gordanac wrote: > Updated to r1120. > Please take a look. lgtm
The CQ bit was checked by gordana.cmiljanovic@imgtec.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643123002/50001
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
On 2014/10/15 17:16:16, I haz the power (commit-bot) wrote: > No LGTM from a valid reviewer yet. Only full committers are accepted. > Even if an LGTM may have been provided, it was from a non-committer or > a provisional committer, _not_ a full super star committer. > See http://www.chromium.org/getting-involved/become-a-committer > Note that this has nothing to do with OWNERS files. lgtm rd 2
The CQ bit was checked by gordana.cmiljanovic@imgtec.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643123002/50001
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
dxie@google.com changed reviewers: + dxie@google.com, gordana.cmiljanovic@imgtec.com - Gordana.Cmiljanovic@imgtec.com
lgtm
The CQ bit was checked by gordana.cmiljanovic@imgtec.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643123002/50001
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Do try bots pass?
lgtm Looking thru the revisions http://git.chromium.org/gitweb/?p=external/libyuv.git;a=summary this is the head code revision, which is 1120, and try bots appear to pass on arm platforms and copyrow_avx, so we should be good. Note there was also a small mips change - on of the unaligned functions was removed.
The CQ bit was checked by fbarchard@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643123002/50001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by gordana.cmiljanovic@imgtec.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643123002/50001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
On 2014/10/16 10:28:20, I haz the power (commit-bot) wrote: > Try jobs failed on following builders: > win_chromium_x64_rel_swarming on tryserver.chromium.win > (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...) Looks like this could be a legit failure? YuvToRgbTest.Clipping
ya, I think I see the problem... unaligned memory. filed bug, fix coming. Could also turn off assembly for win64 with a macro On Thu, Oct 16, 2014 at 3:30 AM, <benm@google.com> wrote: > On 2014/10/16 10:28:20, I haz the power (commit-bot) wrote: > >> Try jobs failed on following builders: >> win_chromium_x64_rel_swarming on tryserver.chromium.win >> > > (http://build.chromium.org/p/tryserver.chromium.win/ > builders/win_chromium_x64_rel_swarming/builds/19666) > > Looks like this could be a legit failure? > > YuvToRgbTest.Clipping > > https://codereview.chromium.org/643123002/ > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Giving a try to r1125 (https://chromium.googlesource.com/external/libyuv/+/9107460c7f76a10cc4122d91e...)
The CQ bit was checked by gordana.cmiljanovic@imgtec.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643123002/70001
Message was sent while issue was closed.
Committed patchset #3 (id:70001)
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/20429ab66f5eee7af8df407bb2cab4af624f650b Cr-Commit-Position: refs/heads/master@{#300098} |