Use app_list_service_disabled in Athena

Use app_list_service_disabled in Athena

Athena does not have an ash::Shell. Use app_list_service_disabled for now.

BUG=414341
TEST=None

Committed: https://crrev.com/97b3e32f2ea8970c8f75c100523dc3c0091fc8b4
Cr-Commit-Position: refs/heads/master@{#299512}

[pkotwicz, 2014-10-10 21:14:57]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2014-10-10 21:43:45]

Patchset #1 (id:140001) has been deleted

[pkotwicz, 2014-10-10 21:46:18]

Patchset #1 (id:170001) has been deleted

[pkotwicz, 2014-10-10 23:04:18]

Patchset #1 (id:200001) has been deleted

[pkotwicz, 2014-10-10 23:46:02]

pkotwicz@chromium.org changed reviewers:
+ oshima@chromium.org

[pkotwicz, 2014-10-10 23:46:03]

Oshima, can you please take a look?

This is the first half for https://codereview.chromium.org/634313004/ I believe
that you have looked at all of the code in this CL before

[oshima, 2014-10-11 01:20:36]

lgtm

https://codereview.chromium.org/643103003/diff/240001/chrome/browser/ui/ash/a...
File chrome/browser/ui/ash/ash_util.cc (right):

https://codereview.chromium.org/643103003/diff/240001/chrome/browser/ui/ash/a...
chrome/browser/ui/ash/ash_util.cc:19: #endif
nit: #else, and include headers only for !cros.

[pkotwicz, 2014-10-12 01:53:28]

asargent@ can you please take a look at the changes in webstore_private_api.cc

In the coming weeks I am going to be doing many changes (hopefully small) in
order to make the webstore and management APIs work without a Browser object.

[pkotwicz, 2014-10-12 01:53:42]

pkotwicz@chromium.org changed reviewers:
+ asargent@chromium.org

[asargent_no_longer_on_chrome, 2014-10-13 17:30:01]

webstore_private_api.cc lgtm

> In the coming weeks I am going to be doing many changes (hopefully small) in
> order to make the webstore and management APIs work without a Browser object.

Note that an important security property of the webstorePrivate install flow is
the assumption that the user had a chance to see description/reviews/ratings in
the webstore page for the item. For other types of installations, we have the
"inline installation dialog" which shows some of this information and contains a
link the user can click to get to the webstore page. 

If you're designing for some new installation flow that would presume to use the
webstorePrivate APIs but *not* show the webstore detail pages, you should make
sure to get sign-off on this from the chrome security folks if you haven't
already (meacer@ would be a good person to start talking with).

[pkotwicz, 2014-10-13 17:52:31]

pkotwicz@chromium.org changed reviewers:
+ sky@chromium.org

[pkotwicz, 2014-10-13 17:52:31]

sky@ for OWNERs

asargent@ thank you for the heads up. I do not think that there is a plan to
change what is displayed when installing an app. It is still unclear how it will
be displayed. Athena dialogs will have a different border style than dialogs on
Windows and ChromeOS. We may or may not have an app list.

[asargent_no_longer_on_chrome, 2014-10-13 18:03:37]

> asargent@ thank you for the heads up. I do not think that there is a plan to
> change what is displayed when installing an app. It is still unclear how it
will
> be displayed. Athena dialogs will have a different border style than dialogs
on
> Windows and ChromeOS. We may or may not have an app list.

I wasn't referring to the dialog style - I was referring to the fact that
currently the webstorePrivate APIs operate within a tab navigated to a page like
https://chrome.google.com/webstore/detail/hangouts/nckgahadagoaajjgafhacjanao...
where the user clicks on the install button. I may have misunderstood the
context of your change removing the dependency on Browser objects - will there
still be a renderer showing the webstore page? (But not hosted in a Browser
object?)

[pkotwicz, 2014-10-13 18:38:00]

That's exactly right. There will be a renderer which is not hosted by a Browser
object which will display the webstore page.
Athena has an object called a WebActivity which is that same as a browser object
in all respects except that:
- It has minimal Chrome. No toolbar, page actions or browser actions
- It can only display one tab

On 2014/10/13 18:03:37, asargent wrote:
> > asargent@ thank you for the heads up. I do not think that there is a plan to
> > change what is displayed when installing an app. It is still unclear how it
> will
> > be displayed. Athena dialogs will have a different border style than dialogs
> on
> > Windows and ChromeOS. We may or may not have an app list.
> 
> I wasn't referring to the dialog style - I was referring to the fact that
> currently the webstorePrivate APIs operate within a tab navigated to a page
like
>
https://chrome.google.com/webstore/detail/hangouts/nckgahadagoaajjgafhacjanao...
> where the user clicks on the install button. I may have misunderstood the
> context of your change removing the dependency on Browser objects - will there
> still be a renderer showing the webstore page? (But not hosted in a Browser
> object?)

[asargent_no_longer_on_chrome, 2014-10-13 19:41:05]

On 2014/10/13 18:38:00, pkotwicz wrote:
> That's exactly right. There will be a renderer which is not hosted by a
Browser
> object which will display the webstore page.
> Athena has an object called a WebActivity which is that same as a browser
object
> in all respects except that:
> - It has minimal Chrome. No toolbar, page actions or browser actions
> - It can only display one tab

Ok, that makes sense. No need for additional security review in that case.

[pkotwicz, 2014-10-14 02:59:35]

sky@, ping?

[sky, 2014-10-14 16:49:06]

LGTM

[pkotwicz, 2014-10-14 16:51:08]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-10-14 16:52:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/643103003/320001

[commit-bot: I haz the power, 2014-10-14 18:14:30]

Committed patchset #2 (id:320001)

[commit-bot: I haz the power, 2014-10-14 18:15:44]

Patchset 2 (id:??) landed as
https://crrev.com/97b3e32f2ea8970c8f75c100523dc3c0091fc8b4
Cr-Commit-Position: refs/heads/master@{#299512}