Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 643093003: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
CC:
avayvod+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, hclam+watch_chromium.org, hguihot+watch_chromium.org, hubbe+watch_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, mcasas+watch_chromium.org, mikhal+watch_chromium.org, miu+watch_chromium.org, posciak+watch_chromium.org, pwestin+watch_google.com, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. BUG=423621 Committed: https://crrev.com/978b5a5cf18a4a12fee3d43d5802a0d2397d5537 Cr-Commit-Position: refs/heads/master@{#300154}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -17 lines) Patch
M media/base/android/browser_cdm_factory_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/pipeline_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/test/utility/udp_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/pipeline_integration_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/midi/midi_manager_usb_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M media/video/capture/fake_video_capture_device_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/video/capture/video_capture_device_unittest.cc View 8 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
6 years, 2 months ago (2014-10-16 18:44:56 UTC) #2
vrk (LEFT CHROMIUM)
lgtm
6 years, 2 months ago (2014-10-17 19:49:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643093003/1
6 years, 2 months ago (2014-10-17 19:50:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 20:11:46 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 20:20:53 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/978b5a5cf18a4a12fee3d43d5802a0d2397d5537
Cr-Commit-Position: refs/heads/master@{#300154}

Powered by Google App Engine
This is Rietveld 408576698