Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1605)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: mojo/public/tools/bindings/generators/mojom_python_generator.py

Issue 643023003: mojo: Add maps to python bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« mojo/public/python/mojo/bindings/descriptor.py ('K') | « mojo/public/python/mojo/bindings/descriptor.py ('k') | mojo/python/tests/bindings_serialization_deserialization_unittest.py » ('j') | mojo/python/tests/bindings_serialization_deserialization_unittest.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/tools/bindings/generators/mojom_python_generator.py
diff --git a/mojo/public/tools/bindings/generators/mojom_python_generator.py b/mojo/public/tools/bindings/generators/mojom_python_generator.py
index 7e580ec1727baa646d47acfd37bfca625fa8a0ea..ba7828414b663297feaf0e1b39d5e5eff4ae9bcd 100644
--- a/mojo/public/tools/bindings/generators/mojom_python_generator.py
+++ b/mojo/public/tools/bindings/generators/mojom_python_generator.py
@@ -145,6 +145,15 @@ def GetFieldType(kind, field=None):
array_type = 'NativeArrayType'
return '_descriptor.%s(%s)' % (array_type, ', '.join(arguments))
+ if mojom.IsMapKind(kind):
+ arguments = [
+ GetFieldType(kind.key_kind),
+ GetFieldType(kind.value_kind),
+ ]
+ if mojom.IsNullableKind(kind):
+ arguments.append('nullable=True')
+ return '_descriptor.MapType(%s)' % ', '.join(arguments)
+
if mojom.IsStructKind(kind):
arguments = [ 'lambda: %s' % GetStructClass(kind) ]
if mojom.IsNullableKind(kind):
« mojo/public/python/mojo/bindings/descriptor.py ('K') | « mojo/public/python/mojo/bindings/descriptor.py ('k') | mojo/python/tests/bindings_serialization_deserialization_unittest.py » ('j') | mojo/python/tests/bindings_serialization_deserialization_unittest.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698