mojo: Add maps to python bindings.

mojo: Add maps to python bindings.

BUG=413863
R=sdefresne@chromium.org,erg@chromium.org

Committed: https://crrev.com/8b04ce894fc59fe165df6025b07399311e81acb6
Cr-Commit-Position: refs/heads/master@{#299276}

[sdefresne, 2014-10-10 15:10:27]

https://codereview.chromium.org/643023003/diff/1/mojo/public/python/mojo/bind...
File mojo/public/python/mojo/bindings/descriptor.py (right):

https://codereview.chromium.org/643023003/diff/1/mojo/public/python/mojo/bind...
mojo/public/python/mojo/bindings/descriptor.py:438: key_values = value.items()
nit: I think it would be clearer as:

keys, values = [], []
for key, value in value.iteritems():
  keys.append(key)
  values.append(value)

https://codereview.chromium.org/643023003/diff/1/mojo/python/tests/bindings_s...
File mojo/python/tests/bindings_serialization_deserialization_unittest.py
(right):

https://codereview.chromium.org/643023003/diff/1/mojo/python/tests/bindings_s...
mojo/python/tests/bindings_serialization_deserialization_unittest.py:35: x =
x.items()
I not sure whether python guarantee that dict1.items() and dict2.items() always
returns the elements in the same order if they have the same keys. I think it
would be safer to sort the two lists on their key (if it make sense) or to add a
special treatment for dict here (by iterating on one of the dict and comparing
it to the other).

[qsr, 2014-10-10 15:36:06]

https://codereview.chromium.org/643023003/diff/1/mojo/public/python/mojo/bind...
File mojo/public/python/mojo/bindings/descriptor.py (right):

https://codereview.chromium.org/643023003/diff/1/mojo/public/python/mojo/bind...
mojo/public/python/mojo/bindings/descriptor.py:438: key_values = value.items()
On 2014/10/10 15:10:26, sdefresne wrote:
> nit: I think it would be clearer as:
> 
> keys, values = [], []
> for key, value in value.iteritems():
>   keys.append(key)
>   values.append(value)

Done.

https://codereview.chromium.org/643023003/diff/1/mojo/python/tests/bindings_s...
File mojo/python/tests/bindings_serialization_deserialization_unittest.py
(right):

https://codereview.chromium.org/643023003/diff/1/mojo/python/tests/bindings_s...
mojo/python/tests/bindings_serialization_deserialization_unittest.py:35: x =
x.items()
On 2014/10/10 15:10:27, sdefresne wrote:
> I not sure whether python guarantee that dict1.items() and dict2.items()
always
> returns the elements in the same order if they have the same keys. I think it
> would be safer to sort the two lists on their key (if it make sense) or to add
a
> special treatment for dict here (by iterating on one of the dict and comparing
> it to the other).

Done.

[sdefresne, 2014-10-10 15:38:35]

lgtm

https://codereview.chromium.org/643023003/diff/90001/mojo/public/python/mojo/...
File mojo/public/python/mojo/bindings/descriptor.py (right):

https://codereview.chromium.org/643023003/diff/90001/mojo/public/python/mojo/...
mojo/public/python/mojo/bindings/descriptor.py:450: 'keys and values have not
the same length.')
nit: "keys and values do not have the same length" maybe?

[qsr, 2014-10-10 15:53:28]

https://codereview.chromium.org/643023003/diff/90001/mojo/public/python/mojo/...
File mojo/public/python/mojo/bindings/descriptor.py (right):

https://codereview.chromium.org/643023003/diff/90001/mojo/public/python/mojo/...
mojo/public/python/mojo/bindings/descriptor.py:450: 'keys and values have not
the same length.')
On 2014/10/10 15:38:35, sdefresne wrote:
> nit: "keys and values do not have the same length" maybe?

Done.

[qsr, 2014-10-10 15:53:35]

The CQ bit was checked by qsr@chromium.org

[commit-bot: I haz the power, 2014-10-10 15:53:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/643023003/170001

[commit-bot: I haz the power, 2014-10-10 16:58:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-10 16:58:36]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[qsr, 2014-10-13 07:51:43]

The CQ bit was checked by qsr@chromium.org

[commit-bot: I haz the power, 2014-10-13 07:52:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/643023003/170001

[commit-bot: I haz the power, 2014-10-13 07:59:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-13 07:59:12]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[qsr, 2014-10-13 08:37:46]

The CQ bit was checked by qsr@chromium.org

[commit-bot: I haz the power, 2014-10-13 08:38:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/643023003/460001

[commit-bot: I haz the power, 2014-10-13 09:46:24]

Committed patchset #4 (id:460001)

[commit-bot: I haz the power, 2014-10-13 09:47:38]

Patchset 4 (id:??) landed as
https://crrev.com/8b04ce894fc59fe165df6025b07399311e81acb6
Cr-Commit-Position: refs/heads/master@{#299276}