[chromedriver] Delete ResponseInfo objects after command response

[chromedriver] Delete ResponseInfo objects after command response

BUG=chromedriver:926
Committed: https://crrev.com/f0351e1c0aefffc8580b77d0f4701acba7da8506
Cr-Commit-Position: refs/heads/master@{#299327}

[samuong, 2014-10-11 02:13:09]

samuong@chromium.org changed reviewers:
+ stgao@chromium.org

[samuong, 2014-10-11 02:13:09]

We're not deleting ResponseInfo objects from
DevToolsClientImpl::response_info_map_, and for long-running tests this can grow
very large.

I've been running a test for about 20 hours now and chromedriver memory usage
grew from 12 MB to 1 GB. With this patch applied, it is still at 12 MB after the
20 hours.

I've also run all the unit, java and py tests locally, and this does not throw
up any regressions.

[stgao, 2014-10-13 17:55:00]

lgtm
But as discussed offline, you may want to double check whether the response was
returned correctly to the caller of DevToolsClient.

[samuong, 2014-10-13 17:58:50]

On 2014/10/13 17:55:00, Shuotao wrote:
> lgtm
> But as discussed offline, you may want to double check whether the response
was
> returned correctly to the caller of DevToolsClient.

This is done in DevToolsClientImpl::SendCommandInternal() which has its own
linked_ptr to the ResponseInfo object. So even though it is deleted from the
map, the object won't be deleted until after SendCommandInternal() completes, so
it is able to be returned correctly to the caller of DevToolsClient.

[samuong, 2014-10-13 17:58:55]

The CQ bit was checked by samuong@chromium.org

[commit-bot: I haz the power, 2014-10-13 17:59:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/643003003/1

[commit-bot: I haz the power, 2014-10-13 18:33:21]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-10-13 18:34:09]

Patchset 1 (id:??) landed as
https://crrev.com/f0351e1c0aefffc8580b77d0f4701acba7da8506
Cr-Commit-Position: refs/heads/master@{#299327}