Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issue 642993002: Fix unbounded allocation of GL queries (Closed)

Created:
6 years, 2 months ago by ccameron
Modified:
6 years, 2 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, reveman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix unbounded allocation of GL queries Check to see if previously-allocated queries are done before allocating new ones. It turns out that destroying a massive list of queries accounts for 50% of our watchdog timeouts in the GPU process. BUG=398072 Committed: https://crrev.com/b4cce56ab9c457efe70cb142929308e04bbd8522 Cr-Commit-Position: refs/heads/master@{#299164}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M cc/resources/texture_uploader.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ccameron
So, this was funny.
6 years, 2 months ago (2014-10-10 00:13:28 UTC) #2
enne (OOO)
Oh, my. lgtm +reveman FYI
6 years, 2 months ago (2014-10-10 18:23:03 UTC) #3
ccameron
Thanks!
6 years, 2 months ago (2014-10-10 18:32:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642993002/1
6 years, 2 months ago (2014-10-10 18:32:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 19:45:39 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 19:46:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b4cce56ab9c457efe70cb142929308e04bbd8522
Cr-Commit-Position: refs/heads/master@{#299164}

Powered by Google App Engine
This is Rietveld 408576698