cc: Make PictureLayerImpl use a better choice for animated raster scale.

cc/animation/keyframed_animation_curve.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 
 #include "cc/animation/keyframed_animation_curve.h"
 #include "ui/gfx/animation/tween.h"
 #include "ui/gfx/box_f.h"
 
@@ skipping 348 matching lines @@
 
 bool KeyframedTransformAnimationCurve::IsTranslation() const {
   for (size_t i = 0; i < keyframes_.size(); ++i) {
     if (!keyframes_[i]->Value().IsTranslation() &&
         !keyframes_[i]->Value().IsIdentity())
       return false;
   }
   return true;
 }
 
-bool KeyframedTransformAnimationCurve::MaximumScale(float* max_scale) const {
+bool KeyframedTransformAnimationCurve::MaximumTargetScale(
+    float* max_scale) const {
   DCHECK_GE(keyframes_.size(), 2ul);
   *max_scale = 0.f;
   for (size_t i = 1; i < keyframes_.size(); ++i) {
     float min_progress = 0.f;
     float max_progress = 1.f;
     if (keyframes_[i - 1]->timing_function())
       keyframes_[i - 1]->timing_function()->Range(&min_progress, &max_progress);
 
-    float max_scale_for_segment = 0.f;
-    if (!keyframes_[i]->Value().MaximumScale(keyframes_[i - 1]->Value(),
-                                             min_progress,
-                                             max_progress,
-                                             &max_scale_for_segment))
+    gfx::Vector3dF target_scale_for_segment;
+    if (!keyframes_[i]->Value().ScaleComponent(&target_scale_for_segment))
       return false;
-
-    *max_scale = std::max(*max_scale, max_scale_for_segment);
+    float max_scale_for_segment =
+        fmaxf(std::abs(target_scale_for_segment.x()),

[vmpstr, 2014/10/10 03:31:23]

hehe, why fmaxf then? :P Also, should this be std::fmaxf?

[danakj, 2014/10/10 05:30:11]

Its not in std::  it actually is a co.piler defined thing I think. Anyway I
noticed it was cheaper than std::max when I was playing with the geometry types
and in lining stuff. 

Oh and c++11 should be just fmax apparently
http://www.cplusplus.com/reference/cmath/fmax/

[vmpstr, 2014/10/10 07:26:24]

If it's cheaper, then that's good enough. Right maybe I was confusing std::fmax
with c++11 stuff.

+              fmaxf(std::abs(target_scale_for_segment.y()),
+                    std::abs(target_scale_for_segment.z())));
+    *max_scale = fmaxf(*max_scale, max_scale_for_segment);
   }
   return true;
 }
 
 scoped_ptr<KeyframedFilterAnimationCurve> KeyframedFilterAnimationCurve::
     Create() {
   return make_scoped_ptr(new KeyframedFilterAnimationCurve);
 }
 
 KeyframedFilterAnimationCurve::KeyframedFilterAnimationCurve() {}
@@ skipping 38 matching lines @@
 bool KeyframedFilterAnimationCurve::HasFilterThatMovesPixels() const {
   for (size_t i = 0; i < keyframes_.size(); ++i) {
     if (keyframes_[i]->Value().HasFilterThatMovesPixels()) {
       return true;
     }
   }
   return false;
 }
 
 }  // namespace cc