Source/core/xml/XPathStep.cpp - Issue 642973003: Introduce typed Node/Element iterators for range-based for loops of C++11.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/xml/XPathStep.cpp

Issue 642973003: Introduce typed Node/Element iterators for range-based for loops of C++11. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rename `from` to `fromNext`. Make some parameters const references. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/xml/XPathStep.cpp

diff --git a/Source/core/xml/XPathStep.cpp b/Source/core/xml/XPathStep.cpp

index 7ef3d677d663d0522417b7f77f6404cc9ab5925e..16662a20c105afb9fe6c324c0da9907989a5f415 100644

--- a/Source/core/xml/XPathStep.cpp

+++ b/Source/core/xml/XPathStep.cpp

@@ -331,9 +331,9 @@ void Step::nodesInAxis(EvaluationContext& evaluationContext, Node* context, Node

case FollowingAxis:

if (context->isAttributeNode()) {

- for (Node* p = NodeTraversal::next(*toAttr(context)->ownerElement()); p; p = NodeTraversal::next(*p)) {

- if (nodeMatches(evaluationContext, p, FollowingAxis, nodeTest()))

- nodes.append(p);

+ for (Node& p : NodeTraversal::fromNext(*toAttr(context)->ownerElement())) {

+ if (nodeMatches(evaluationContext, &p, FollowingAxis, nodeTest()))

+ nodes.append(&p);

}

} else {

for (Node* p = context; !isRootDomNode(p); p = p->parentNode()) {