Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3388)

Unified Diff: pkg/analysis_server/lib/src/services/completion/imported_computer.dart

Issue 642973002: add if statement condition suggestions (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/completion/completion_test_util.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/services/completion/imported_computer.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/imported_computer.dart b/pkg/analysis_server/lib/src/services/completion/imported_computer.dart
index 5501700ba6bf7c9f0895d0df6d443ae999d09380..3e8a85518cc278828eee6f609cae1cd25452013b 100644
--- a/pkg/analysis_server/lib/src/services/completion/imported_computer.dart
+++ b/pkg/analysis_server/lib/src/services/completion/imported_computer.dart
@@ -104,6 +104,18 @@ class _ImportedVisitor extends GeneralizingAstVisitor<Future<bool>> {
}
@override
+ Future<bool> visitIfStatement(IfStatement node) {
+ Token leftParen = node.leftParenthesis;
+ if (leftParen != null && request.offset >= leftParen.end) {
+ Token rightParen = node.rightParenthesis;
+ if (rightParen == null || request.offset <= rightParen.offset) {
+ return _addImportedElementSuggestions();
+ }
+ }
+ return new Future.value(false);
+ }
+
+ @override
Future<bool> visitInterpolationExpression(InterpolationExpression node) {
Expression expression = node.expression;
if (expression is SimpleIdentifier) {
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/completion/completion_test_util.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698