Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 642953003: Revert of Revert of ui::PlatformWindowDelegate::OnClosed() isn't called when a ui::X11Window is closed (Closed)

Created:
6 years, 2 months ago by brettw
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of ui::PlatformWindowDelegate::OnClosed() isn't called when a ui::X11Window is closed (patchset #1 id:1 of https://codereview.chromium.org/647573002/) Reason for revert: This was not the cause of the regression. See http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/6569 Original issue's description: > Revert of ui::PlatformWindowDelegate::OnClosed() isn't called when a ui::X11Window is closed (patchset #1 id:1 of https://codereview.chromium.org/644443002/) > > Reason for revert: > Only cl that seems related to http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/6561 falures. > > Original issue's description: > > ui::PlatformWindowDelegate::OnClosed() isn't called when a ui::X11Window is closed > > > > This problem manifests itself in simple Mojo apps that use NativeViewportService on X11. When the NativeViewport window is closed, the NativeViewportClient OnDestroyed() method does not run. > > > > BUG=421536 > > > > Committed: https://crrev.com/b37606e1c2a6703e58a61a978e8e32be72acae0c > > Cr-Commit-Position: refs/heads/master@{#298926} > > TBR=ben@chromium.org,hansmuller@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=421536 > > Committed: https://crrev.com/b93c31988a55a9cb2a328e39520f56788585b542 > Cr-Commit-Position: refs/heads/master@{#298985} TBR=ben@chromium.org,hansmuller@chromium.org,jwd@chromium.org NOTREECHECKS=true NOTRY=true BUG=421536 Committed: https://crrev.com/f9fe3305fc6097e26db01b4b38e362160b0d4679 Cr-Commit-Position: refs/heads/master@{#298999}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/platform_window/x11/x11_window.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
brettw
6 years, 2 months ago (2014-10-09 22:37:53 UTC) #1
Created Revert of Revert of ui::PlatformWindowDelegate::OnClosed() isn't called
when a ui::X11Window is closed

Powered by Google App Engine
This is Rietveld 408576698