Issue 642933008: ServiceWorker: Remove unnecessary NeedsRebaseline for fetch-event.html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 642933008: ServiceWorker: Remove unnecessary NeedsRebaseline for fetch-event.html (Closed)

Created:
6 years, 2 months ago by nhiroki

Modified:
6 years, 2 months ago

Reviewers:
nhiroki

CC:
blink-reviews, serviceworker-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

ServiceWorker: Remove unnecessary NeedsRebaseline for fetch-event.html BUG=388375, 401381 TBR=nhiroki@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183640

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -13 lines)			Patch
	M	LayoutTests/TestExpectations	View		2 chunks	+1 line, -2 lines	0 comments	Download
	D	LayoutTests/platform/win/http/tests/serviceworker/fetch-event-expected.txt	View		1 chunk	+0 lines, -11 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

nhiroki

fetch-event.html doesn't need Rebaseline (I'm not sure why this was marked...)

6 years, 2 months ago (2014-10-14 04:27:58 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642933008/1

6 years, 2 months ago (2014-10-14 04:29:42 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as 183640

6 years, 2 months ago (2014-10-14 04:30:29 UTC) #5

falken

6 years, 2 months ago (2014-10-14 04:30:50 UTC) #6

Message was sent while issue was closed.

On 2014/10/14 04:27:58, nhiroki wrote:
> fetch-event.html doesn't need Rebaseline (I'm not sure why this was marked...)

I think you meant to TBR someone else?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages