Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 642933002: Revert of Use BBH reserve hook to preallocate space for tiles. (Closed)

Created:
6 years, 2 months ago by mtklein
Modified:
6 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Use BBH reserve hook to preallocate space for tiles. (patchset #2 id:80001 of https://codereview.chromium.org/639823005/) Reason for revert: failed assertion "fXTiles * fYTiles != 0" Original issue's description: > Use BBH reserve hook to preallocate space for tiles. > > Before getting too far into changing how SkTileGrid stores its tiles, I figured I'd > better see how much I can tweak out the existing format. Cleverly, that way > any improvements I make by changing the format will look that much less > impressive. > > This CL looks like it will be a 5-15% win in time spent recording, with no effect > on playback. > > This CL also shrinks the tiles to fit exactly when we're done inserting, > using newly added SkTDArray::shrinkToFit(). It's quite cheap to run (maybe > taking back 1-2% from those 5-15% wins), and means we'll lug around about 15% > fewer bytes in the tile grids. Note though this strategy temporarily uses up to > 30% more memory while building the tile grid. For our largest SKPs, that's > maybe 75-100K extra. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/52455cbc02d7f480d988ae7cdacc11ad69078c2c TBR=reed@google.com,robertphillips@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/7062a262e27d89411a7b6bcc0162d230a2b2e36c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -34 lines) Patch
M include/core/SkTDArray.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/core/SkTileGrid.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkTileGrid.cpp View 1 chunk +1 line, -26 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Use BBH reserve hook to preallocate space for tiles.
6 years, 2 months ago (2014-10-09 20:54:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642933002/1
6 years, 2 months ago (2014-10-09 20:55:15 UTC) #2
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 20:55:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 7062a262e27d89411a7b6bcc0162d230a2b2e36c

Powered by Google App Engine
This is Rietveld 408576698