Source/core/css/resolver/TransformBuilder.h - Issue 64293008: Wrap CSS length conversion arguments in an object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/TransformBuilder.h

Issue 64293008: Wrap CSS length conversion arguments in an object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: don't make it noncopyable ; clang doesn't do the RVO stuffs? Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/resolver/TransformBuilder.h

diff --git a/Source/core/css/resolver/TransformBuilder.h b/Source/core/css/resolver/TransformBuilder.h

index 7e265c1532b9e9609fa02a6e5c094bb323b969aa..a3ac2e0b0f5a49310aa15a8d033a1da8ad2a988c 100644

--- a/Source/core/css/resolver/TransformBuilder.h

+++ b/Source/core/css/resolver/TransformBuilder.h

@@ -36,8 +36,8 @@

namespace WebCore {

+class CSSToLengthConversionData;

class CSSValue;

-class RenderStyle;

class TransformBuilder {

WTF_MAKE_NONCOPYABLE(TransformBuilder); WTF_MAKE_FAST_ALLOCATED;

@@ -45,7 +45,7 @@ public:

TransformBuilder();

~TransformBuilder();

- static bool createTransformOperations(CSSValue* inValue, const RenderStyle* inStyle, const RenderStyle* rootStyle, TransformOperations& outOperations);

+ static bool createTransformOperations(CSSValue* inValue, const CSSToLengthConversionData&, TransformOperations& outOperations);

};

} // namespace WebCore

« no previous file with comments | « Source/core/css/resolver/StyleResolverState.cpp ('k') | Source/core/css/resolver/TransformBuilder.cpp » ('j') | no next file with comments »