Source/core/css/BasicShapeFunctions.cpp - Issue 64293008: Wrap CSS length conversion arguments in an object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/BasicShapeFunctions.cpp

Issue 64293008: Wrap CSS length conversion arguments in an object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: don't make it noncopyable ; clang doesn't do the RVO stuffs? Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/BasicShapeFunctions.cpp

diff --git a/Source/core/css/BasicShapeFunctions.cpp b/Source/core/css/BasicShapeFunctions.cpp

index 3f827df58b6a132d1863ac049364044bc261e8a2..a49ea1495f13840133cffa33215d08677639a282 100644

--- a/Source/core/css/BasicShapeFunctions.cpp

+++ b/Source/core/css/BasicShapeFunctions.cpp

@@ -116,7 +116,7 @@ PassRefPtr<CSSValue> valueForBasicShape(const RenderStyle& style, const BasicSha

static Length convertToLength(const StyleResolverState& state, CSSPrimitiveValue* value)

{

- return value->convertToLength<FixedConversion | PercentConversion>(state.style(), state.rootElementStyle(), state.style()->effectiveZoom());

+ return value->convertToLength<FixedConversion | PercentConversion>(state.cssToLengthConversionData());

}

PassRefPtr<BasicShape> basicShapeForValue(const StyleResolverState& state, const CSSBasicShape* basicShapeValue)

« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/css/CSSCalculationValue.h » ('j') | no next file with comments »