Source/core/css/CSSCalculationValueTest.cpp - Issue 64293008: Wrap CSS length conversion arguments in an object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSCalculationValueTest.cpp

Issue 64293008: Wrap CSS length conversion arguments in an object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: bool for useEffectiveZoom instead of -1 magic number Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/CSSCalculationValueTest.cpp

diff --git a/Source/core/css/CSSCalculationValueTest.cpp b/Source/core/css/CSSCalculationValueTest.cpp

index 687a3ea0a7746b0ab97847f40b4cdb732255b879..5787552378448cd5c3d47c70d174d6fb8f24638c 100644

--- a/Source/core/css/CSSCalculationValueTest.cpp

+++ b/Source/core/css/CSSCalculationValueTest.cpp

@@ -32,6 +32,7 @@

#include "core/css/CSSCalculationValue.h"

#include "core/css/CSSPrimitiveValue.h"

+#include "core/css/CSSToLengthConversionData.h"

#include "core/rendering/style/RenderStyle.h"

#include "core/rendering/style/StyleInheritedData.h"

@@ -46,7 +47,7 @@ void testExpression(PassRefPtr<CSSCalcExpressionNode> expression, const RenderSt

EXPECT_TRUE(

expression->equals(

*CSSCalcValue::createExpressionNode(

- expression->toCalcValue(style, style, style->effectiveZoom()).get(),

+ expression->toCalcValue(CSSToLengthConversionData(style, style)).get(),

style->effectiveZoom()).get()));

}