Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: Source/core/css/MediaQueryEvaluator.cpp

Issue 64293008: Wrap CSS length conversion arguments in an object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: erm.. use DEFINE_STATIC_REF Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/MediaQueryEvaluator.cpp
diff --git a/Source/core/css/MediaQueryEvaluator.cpp b/Source/core/css/MediaQueryEvaluator.cpp
index 3674430cd896a652d2b662b2b47d40b8107035f4..4c39450575759579db28742f6b77ae1117ff0ef6 100644
--- a/Source/core/css/MediaQueryEvaluator.cpp
+++ b/Source/core/css/MediaQueryEvaluator.cpp
@@ -34,6 +34,7 @@
#include "core/css/CSSAspectRatioValue.h"
#include "core/css/CSSHelper.h"
#include "core/css/CSSPrimitiveValue.h"
+#include "core/css/CSSToLengthConversionData.h"
#include "core/css/MediaFeatureNames.h"
#include "core/css/MediaList.h"
#include "core/css/MediaQuery.h"
@@ -347,7 +348,7 @@ static bool computeLength(CSSValue* value, bool strict, RenderStyle* initialStyl
if (primitiveValue->isLength()) {
// Relative (like EM) and root relative (like REM) units are always resolved against the initial values
// for media queries, hence the two initialStyle parameters.
- result = primitiveValue->computeLength<int>(initialStyle, initialStyle, 1.0 /* multiplier */, true /* computingFontSize */);
Julien - ping for review 2013/11/26 05:31:07 /* zoom */ ?
Timothy Loh 2013/11/27 05:44:51 Err okay sure. Not sure why I dropped the comment.
+ result = primitiveValue->computeLength<int>(CSSToLengthConversionData(initialStyle, initialStyle, 1.0, true /* computingFontSize */));
return true;
}

Powered by Google App Engine
This is Rietveld 408576698