Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: Source/core/css/CSSToLengthConversionData.h

Issue 64293008: Wrap CSS length conversion arguments in an object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: erm.. use DEFINE_STATIC_REF Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/CSSToLengthConversionData.h
diff --git a/Source/core/css/CSSToLengthConversionData.h b/Source/core/css/CSSToLengthConversionData.h
new file mode 100644
index 0000000000000000000000000000000000000000..7d69782df322948b4971d23636c79721dd38131c
--- /dev/null
+++ b/Source/core/css/CSSToLengthConversionData.h
@@ -0,0 +1,61 @@
+/*
+ * Copyright (C) 2013 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef CSSToLengthConversionData_h
+#define CSSToLengthConversionData_h
+
+namespace WebCore {
+
+class RenderStyle;
+
+class CSSToLengthConversionData {
Julien - ping for review 2013/11/26 05:31:07 Do we really need to allow the copy constructor /
Timothy Loh 2013/11/27 05:44:51 I don't think it matters. Disallowing to avoid any
+public:
+ CSSToLengthConversionData() : m_style(0), m_rootStyle(0), m_zoom(-1), m_computingFontSize(false) { }
Julien - ping for review 2013/11/26 05:31:07 Blink style is one variable per line. Also why do
Timothy Loh 2013/11/27 05:44:51 I've seen having constructor lists on the same lin
+ CSSToLengthConversionData(const RenderStyle* currStyle, const RenderStyle* rootStyle, float zoom = -1, bool computingFontSize = false);
+ const RenderStyle& style() const { return *m_style; }
+ const RenderStyle& rootStyle() const { return *m_rootStyle; }
+ float zoom() const;
+ bool computingFontSize() const { return m_computingFontSize; }
+
+ void setStyle(const RenderStyle* style) { m_style = style; }
+ void setRootStyle(const RenderStyle* rootStyle) { m_rootStyle = rootStyle; }
+
+ CSSToLengthConversionData copyWithAdjustedZoom(float) const;
+
+private:
+ const RenderStyle* m_style;
+ const RenderStyle* m_rootStyle;
+ float m_zoom;
+ bool m_computingFontSize;
+};
+
+} // namespace WebCore
+
+#endif

Powered by Google App Engine
This is Rietveld 408576698