Wrap CSS length conversion arguments in an object

Source/core/css/resolver/ViewportStyleResolver.cpp

 /*
  * Copyright (C) 2012-2013 Intel Corporation. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above
  *    copyright notice, this list of conditions and the following
  *    disclaimer.
@@ skipping 13 matching lines @@
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
  * TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF
  * THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "core/css/resolver/ViewportStyleResolver.h"
 
 #include "CSSValueKeywords.h"
+#include "core/css/CSSToLengthConversionData.h"
 #include "core/css/StylePropertySet.h"
 #include "core/css/StyleRule.h"
 #include "core/dom/Document.h"
 #include "core/dom/NodeRenderStyle.h"
 #include "core/dom/ViewportDescription.h"
 
 namespace WebCore {
 
 ViewportStyleResolver::ViewportStyleResolver(Document* document)
     : m_document(document),
@@ skipping 132 matching lines @@
         || id == CSSPropertyMaxWidth
         || id == CSSPropertyMinWidth);
 
     RefPtr<CSSValue> value = m_propertySet->getPropertyCSSValue(id);
     if (!value || !value->isPrimitiveValue())
         return Length(); // auto
 
     CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value.get());
 
     if (primitiveValue->isLength())
-        return primitiveValue->computeLength<Length>(m_document->renderStyle(), m_document->renderStyle());
+        return primitiveValue->computeLength<Length>(CSSToLengthConversionData(m_document->renderStyle(), m_document->renderStyle(), 1));

[Julien - ping for review, 2013/11/26 05:31:07]

1.0f <- let's avoid implicit conversion.

[Timothy Loh, 2013/11/27 05:44:51]

The style guide says not to append .0f... but after adding the extra ctor (see
other comment) it's needed to disambiguate between bool and float ;-)

 
     if (primitiveValue->isViewportPercentageLength())
         return primitiveValue->viewportPercentageLength();
 
     if (primitiveValue->isPercentage())
         return Length(primitiveValue->getFloatValue(), Percent);
 
     switch (primitiveValue->getValueID()) {
     case CSSValueInternalExtendToZoom:
         return Length(ExtendToZoom);
     case CSSValueAuto:
         return Length();
     default:
         // Unrecognized keyword.
         ASSERT_NOT_REACHED();
         return Length(0, Fixed);
     }
 }
 
 } // namespace WebCore