Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 642923003: [turbofan] Add support for shifted and rotated operands on ARM64. (Closed)

Created:
6 years, 2 months ago by baptiste.afsa1
Modified:
6 years, 2 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Add support for shifted and rotated operands on ARM64. R=bmeurer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24591

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+294 lines, -42 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 3 chunks +64 lines, -18 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +7 lines, -3 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 2 chunks +70 lines, -2 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 6 chunks +153 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
baptiste.afsa1
PTAL
6 years, 2 months ago (2014-10-10 10:55:51 UTC) #1
Benedikt Meurer
lgtm
6 years, 2 months ago (2014-10-13 04:04:37 UTC) #2
baptiste.afsa1
6 years, 2 months ago (2014-10-14 09:29:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24591 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698