Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 642883003: [turbofan] Add support for deferred code. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer
Modified:
6 years, 2 months ago
Reviewers:
dcarney
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Add support for deferred code. Branch can now have an optional hint, when the condition is likely true or false, and if such a hint is present the other basic block will be marked as deferred and placed at the end of the function. We currently use this feature for tagging int32/uint32 in change lowering, and for load/store bounds checks in simplified lowering. TEST=cctest,unittests R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24802

Patch Set 1 #

Patch Set 2 : Add cctest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -20 lines) Patch
M src/compiler/change-lowering.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/code-generator.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/code-generator.cc View 2 chunks +20 lines, -4 lines 0 comments Download
M src/compiler/common-operator.h View 2 chunks +11 lines, -1 line 0 comments Download
M src/compiler/common-operator.cc View 3 chunks +26 lines, -1 line 0 comments Download
M src/compiler/graph-visualizer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/instruction.h View 3 chunks +11 lines, -2 lines 0 comments Download
M src/compiler/instruction.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/operator-properties-inl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/schedule.h View 3 chunks +9 lines, -0 lines 0 comments Download
M src/compiler/schedule.cc View 2 chunks +4 lines, -1 line 0 comments Download
M src/compiler/scheduler.cc View 2 chunks +26 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-scheduler.cc View 1 1 chunk +56 lines, -0 lines 0 comments Download
M test/unittests/compiler/common-operator-unittest.cc View 2 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Benedikt Meurer
PTAL
6 years, 2 months ago (2014-10-22 11:20:24 UTC) #2
dcarney
lgtm
6 years, 2 months ago (2014-10-22 11:23:01 UTC) #3
Benedikt Meurer
6 years, 2 months ago (2014-10-22 11:25:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24802 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698