Moving last app_view bits to extensions.

Moving last app_view bits to extensions.

This CL moves the app_view.js API to extensions.

This is still not enough to get app_view working in app_shell, this will be addressed in a future CL.

BUG=352293
Committed: https://crrev.com/ebe3c763645fe567ecc028b88303cfb73437bd92
Cr-Commit-Position: refs/heads/master@{#299148}

[lfg, 2014-10-09 21:32:12]

lfg@chromium.org changed reviewers:
+ fsamuel@chromium.org

[lfg, 2014-10-09 21:32:13]

PTAL.

[Fady Samuel, 2014-10-09 22:04:52]

lgtm with comment for future CL. Thanks!

https://codereview.chromium.org/642863003/diff/1/extensions/common/api/_api_f...
File extensions/common/api/_api_features.json (right):

https://codereview.chromium.org/642863003/diff/1/extensions/common/api/_api_f...
extensions/common/api/_api_features.json:79: // TODO(fsamuel,kalman): Rename
this appViewGuestInternal.
While you're at it Lucas, could you please take care of this (perhaps in a
separate CL?) Thanks!

[lfg, 2014-10-10 16:16:27]

On 2014/10/09 22:04:52, Fady Samuel wrote:
> lgtm with comment for future CL. Thanks!
> 
>
https://codereview.chromium.org/642863003/diff/1/extensions/common/api/_api_f...
> File extensions/common/api/_api_features.json (right):
> 
>
https://codereview.chromium.org/642863003/diff/1/extensions/common/api/_api_f...
> extensions/common/api/_api_features.json:79: // TODO(fsamuel,kalman): Rename
> this appViewGuestInternal.
> While you're at it Lucas, could you please take care of this (perhaps in a
> separate CL?) Thanks!

Will do.

[lfg, 2014-10-10 16:17:14]

lfg@chromium.org changed reviewers:
+ rockot@chromium.org, sky@chromium.org

[lfg, 2014-10-10 16:17:15]

rockot@chromium.org: Please review changes in 

extensions/*

sky@chromium.org: Please review changes in 

chrome/renderer/resources/renderer_resources.grd

[Ken Rockot(use gerrit already), 2014-10-10 17:28:47]

lgtm

https://codereview.chromium.org/642863003/diff/1/extensions/renderer/resource...
File extensions/renderer/resources/extensions_renderer_resources.grd (right):

https://codereview.chromium.org/642863003/diff/1/extensions/renderer/resource...
extensions/renderer/resources/extensions_renderer_resources.grd:12: <include
name="IDR_APP_VIEW_DENY_JS" file="app_view_deny.js" type="BINDATA" />
nit: Ordering of these two lines seems reversed?

[sky, 2014-10-10 17:59:10]

LGTM

[lfg, 2014-10-10 18:21:44]

https://codereview.chromium.org/642863003/diff/1/extensions/renderer/resource...
File extensions/renderer/resources/extensions_renderer_resources.grd (right):

https://codereview.chromium.org/642863003/diff/1/extensions/renderer/resource...
extensions/renderer/resources/extensions_renderer_resources.grd:12: <include
name="IDR_APP_VIEW_DENY_JS" file="app_view_deny.js" type="BINDATA" />
On 2014/10/10 17:28:47, Ken Rockot wrote:
> nit: Ordering of these two lines seems reversed?

Well, it depends, if you sort by file, yes, but it's correct when sorted by
name.

[lfg, 2014-10-10 18:21:49]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2014-10-10 18:22:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/642863003/1

[commit-bot: I haz the power, 2014-10-10 18:38:13]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-10-10 18:38:46]

Patchset 1 (id:??) landed as
https://crrev.com/ebe3c763645fe567ecc028b88303cfb73437bd92
Cr-Commit-Position: refs/heads/master@{#299148}