Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 642843002: Oilpan: fix build after r183460. (Closed)

Created:
6 years, 2 months ago by sof
Modified:
6 years, 2 months ago
Reviewers:
haraken, oilpan-reviews
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: fix build after r183460. R=haraken BUG=420527 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183472

Patch Set 1 #

Patch Set 2 : Use ALLOW_ONLY_INLINE_ALLOCATION() #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M Source/core/css/CSSGradientValue.cpp View 1 4 chunks +21 lines, -3 lines 4 comments Download

Messages

Total messages: 7 (1 generated)
sof
Please take a look.
6 years, 2 months ago (2014-10-09 15:01:43 UTC) #1
haraken
LGTM https://codereview.chromium.org/642843002/diff/20001/Source/core/css/CSSGradientValue.cpp File Source/core/css/CSSGradientValue.cpp (right): https://codereview.chromium.org/642843002/diff/20001/Source/core/css/CSSGradientValue.cpp#newcode124 Source/core/css/CSSGradientValue.cpp:124: struct VectorTraits<blink::GradientStop> : SimpleClassVectorTraits<blink::GradientStop> { Can we use ...
6 years, 2 months ago (2014-10-09 15:05:35 UTC) #2
sof
https://codereview.chromium.org/642843002/diff/20001/Source/core/css/CSSGradientValue.cpp File Source/core/css/CSSGradientValue.cpp (right): https://codereview.chromium.org/642843002/diff/20001/Source/core/css/CSSGradientValue.cpp#newcode105 Source/core/css/CSSGradientValue.cpp:105: ALLOW_ONLY_INLINE_ALLOCATION(); We could leave this out, not sure it ...
6 years, 2 months ago (2014-10-09 15:10:36 UTC) #3
sof
https://codereview.chromium.org/642843002/diff/20001/Source/core/css/CSSGradientValue.cpp File Source/core/css/CSSGradientValue.cpp (right): https://codereview.chromium.org/642843002/diff/20001/Source/core/css/CSSGradientValue.cpp#newcode105 Source/core/css/CSSGradientValue.cpp:105: ALLOW_ONLY_INLINE_ALLOCATION(); On 2014/10/09 15:10:36, sof wrote: > We could ...
6 years, 2 months ago (2014-10-09 15:32:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642843002/20001
6 years, 2 months ago (2014-10-09 15:33:43 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 15:34:44 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183472

Powered by Google App Engine
This is Rietveld 408576698