Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 642823003: Do not recompute client{width,height} the long way in paddingBoxRect (Closed)

Created:
6 years, 2 months ago by pdr.
Modified:
6 years, 2 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Do not recompute client{width,height} the long way in paddingBoxRect This patch cleans up a case where paddingBoxRect computing client{width,height} used content{width,height} and then added the padding. This was silly because content{width,height} is just the client{width,height} minus the padding. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183565

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/rendering/RenderBox.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
pdr.
6 years, 2 months ago (2014-10-10 18:24:09 UTC) #2
chrishtr
lgtm
6 years, 2 months ago (2014-10-10 21:53:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642823003/1
6 years, 2 months ago (2014-10-10 21:54:11 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 22:58:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183565

Powered by Google App Engine
This is Rietveld 408576698