Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 642813012: Reland "Add unprefixed EME tests for LoadSession()" (Closed)

Created:
6 years, 2 months ago by jrummell
Modified:
6 years, 2 months ago
CC:
chromium-reviews, eme-reviews_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Reland "Add unprefixed EME tests for LoadSession()" Also adds changes for content_browsertests which share the JavaScript files. BUG=338830 TEST=new EME tests pass Committed: https://crrev.com/c467d23a1853a9c740fd20cf96766e9540af50e7 Cr-Commit-Position: refs/heads/master@{#300519}

Patch Set 1 #

Patch Set 2 : another test #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -17 lines) Patch
M chrome/browser/media/encrypted_media_browsertest.cc View 2 chunks +38 lines, -0 lines 0 comments Download
M content/browser/media/encrypted_media_browsertest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/media/media_source_browsertest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M media/cdm/ppapi/external_clear_key/clear_key_cdm.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M media/test/data/eme_player_js/player_utils.js View 1 2 1 chunk +10 lines, -13 lines 0 comments Download
M media/test/data/eme_player_js/test_config.js View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
jrummell
PTAL. Updates the content_browsertests as well this time. No other changes from the previous CL ...
6 years, 2 months ago (2014-10-17 01:09:55 UTC) #2
ddorwin
content/ LGTM. The reland of everything else rsLGTM.
6 years, 2 months ago (2014-10-17 01:34:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642813012/20001
6 years, 2 months ago (2014-10-20 17:36:42 UTC) #5
commit-bot: I haz the power
Failed to apply patch for media/test/data/eme_player_js/player_utils.js: While running git apply --index -3 -p1; error: patch ...
6 years, 2 months ago (2014-10-20 18:44:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642813012/60001
6 years, 2 months ago (2014-10-21 00:04:42 UTC) #11
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-21 02:08:46 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642813012/60001
6 years, 2 months ago (2014-10-21 16:56:57 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:60001)
6 years, 2 months ago (2014-10-21 17:55:40 UTC) #16
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 17:56:36 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c467d23a1853a9c740fd20cf96766e9540af50e7
Cr-Commit-Position: refs/heads/master@{#300519}

Powered by Google App Engine
This is Rietveld 408576698