Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 642813006: content: Rename webkit_test_platform_support* to blink_test_platform_support* (Closed)

Created:
6 years, 2 months ago by tfarina
Modified:
6 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

content: Rename webkit_test_platform_support* to blink_test_platform_support* Trivial file renaming... BUG=359244 TEST=content_shell && content_unittests R=avi@chromium.org Committed: https://crrev.com/4d06f57c22f6fca4583ae9150535bd60f5993c61 Cr-Commit-Position: refs/heads/master@{#300054}

Patch Set 1 #

Total comments: 6

Patch Set 2 : revert windows include change #

Patch Set 3 : REBASE #

Patch Set 4 : fix GN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -364 lines) Patch
M content/content_shell.gypi View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M content/shell/BUILD.gn View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
A + content/shell/app/blink_test_platform_support.h View 1 chunk +4 lines, -4 lines 0 comments Download
A + content/shell/app/blink_test_platform_support_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + content/shell/app/blink_test_platform_support_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + content/shell/app/blink_test_platform_support_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
A + content/shell/app/blink_test_platform_support_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/app/shell_main_delegate.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
D content/shell/app/webkit_test_platform_support.h View 1 chunk +0 lines, -15 lines 0 comments Download
D content/shell/app/webkit_test_platform_support_android.cc View 1 chunk +0 lines, -42 lines 0 comments Download
D content/shell/app/webkit_test_platform_support_linux.cc View 1 chunk +0 lines, -68 lines 0 comments Download
D content/shell/app/webkit_test_platform_support_mac.mm View 1 chunk +0 lines, -96 lines 0 comments Download
D content/shell/app/webkit_test_platform_support_win.cc View 1 chunk +0 lines, -117 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
tfarina
6 years, 2 months ago (2014-10-15 22:36:48 UTC) #1
Avi (use Gerrit)
https://codereview.chromium.org/642813006/diff/1/content/content_shell.gypi File content/content_shell.gypi (right): https://codereview.chromium.org/642813006/diff/1/content/content_shell.gypi#newcode92 content/content_shell.gypi:92: 'shell/app/blink_test_platform_support_win.cc', alphabetize https://codereview.chromium.org/642813006/diff/1/content/shell/app/shell_main_delegate.cc File content/shell/app/shell_main_delegate.cc (right): https://codereview.chromium.org/642813006/diff/1/content/shell/app/shell_main_delegate.cc#newcode59 content/shell/app/shell_main_delegate.cc:59: #include ...
6 years, 2 months ago (2014-10-15 22:42:27 UTC) #2
tfarina
https://codereview.chromium.org/642813006/diff/1/content/shell/app/shell_main_delegate.cc File content/shell/app/shell_main_delegate.cc (right): https://codereview.chromium.org/642813006/diff/1/content/shell/app/shell_main_delegate.cc#newcode59 content/shell/app/shell_main_delegate.cc:59: #include <windows.h> On 2014/10/15 22:42:27, Avi wrote: > Why ...
6 years, 2 months ago (2014-10-15 22:44:28 UTC) #3
tfarina
https://codereview.chromium.org/642813006/diff/1/content/content_shell.gypi File content/content_shell.gypi (right): https://codereview.chromium.org/642813006/diff/1/content/content_shell.gypi#newcode92 content/content_shell.gypi:92: 'shell/app/blink_test_platform_support_win.cc', On 2014/10/15 22:42:27, Avi wrote: > alphabetize Done. ...
6 years, 2 months ago (2014-10-15 22:47:53 UTC) #4
Avi (use Gerrit)
lgtm
6 years, 2 months ago (2014-10-15 22:50:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642813006/20001
6 years, 2 months ago (2014-10-16 13:15:30 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/24816) linux_chromium_compile_dbg_32 on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32/builds/2469) linux_chromium_gn_dbg ...
6 years, 2 months ago (2014-10-16 13:18:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642813006/40001
6 years, 2 months ago (2014-10-17 01:54:04 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/8675) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/25435)
6 years, 2 months ago (2014-10-17 02:20:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642813006/60001
6 years, 2 months ago (2014-10-17 02:41:48 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 2 months ago (2014-10-17 03:37:04 UTC) #16
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 03:37:52 UTC) #17
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/4d06f57c22f6fca4583ae9150535bd60f5993c61
Cr-Commit-Position: refs/heads/master@{#300054}

Powered by Google App Engine
This is Rietveld 408576698