chrome/browser/extensions/global_shortcut_listener_x11.cc - Issue 64273008: [Windows] Finish global and non-global media keys support on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/global_shortcut_listener_x11.cc

Issue 64273008: [Windows] Finish global and non-global media keys support on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: gclient sync. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/global_shortcut_listener_win.cc ('k') | chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/global_shortcut_listener_x11.cc

diff --git a/chrome/browser/extensions/global_shortcut_listener_x11.cc b/chrome/browser/extensions/global_shortcut_listener_x11.cc

index 0574c109841f41fd8dd987a1fc3d1670d99bd129..b0b73ccce57930fc47a34616e576bac94813e860 100644

--- a/chrome/browser/extensions/global_shortcut_listener_x11.cc

+++ b/chrome/browser/extensions/global_shortcut_listener_x11.cc

@@ -110,6 +110,13 @@ bool GlobalShortcutListenerX11::Dispatch(const base::NativeEvent& event) {

void GlobalShortcutListenerX11::RegisterAccelerator(

const ui::Accelerator& accelerator,

GlobalShortcutListener::Observer* observer) {

+ if (registered_hot_keys_.find(accelerator) != registered_hot_keys_.end()) {

+ // The shortcut has already been registered. Some shortcuts, such as

+ // MediaKeys can have multiple targets, all keyed off of the same

+ // accelerator.

+ return;

+ }

int modifiers = GetNativeModifiers(accelerator);

KeyCode keycode = XKeysymToKeycode(x_display_, accelerator.key_code());

base::X11ErrorTracker err_tracker;