chrome/test/data/extensions/api_test/keybinding/non_global_media_keys_1/background.js - Issue 64273008: [Windows] Finish global and non-global media keys support on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/keybinding/non_global_media_keys_1/background.js

Issue 64273008: [Windows] Finish global and non-global media keys support on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address some comments. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/global_shortcut_listener_win.cc ('K') | « chrome/test/data/extensions/api_test/keybinding/non_global_media_keys_0/manifest.json ('k') | chrome/test/data/extensions/api_test/keybinding/non_global_media_keys_1/manifest.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/keybinding/non_global_media_keys_1/background.js

diff --git a/chrome/test/data/extensions/api_test/keybinding/global/background.js b/chrome/test/data/extensions/api_test/keybinding/non_global_media_keys_1/background.js

similarity index 89%

copy from chrome/test/data/extensions/api_test/keybinding/global/background.js

copy to chrome/test/data/extensions/api_test/keybinding/non_global_media_keys_1/background.js

index bfefe228bce859c68f217d3d4ef9d54cff0c7fc7..c90a01051a14f5163ff3d3ae8c660fe2251d119e 100644

--- a/chrome/test/data/extensions/api_test/keybinding/global/background.js

+++ b/chrome/test/data/extensions/api_test/keybinding/non_global_media_keys_1/background.js

@@ -4,7 +4,7 @@

// Called when the user activates the command.

chrome.commands.onCommand.addListener(function(command) {

- if (command == "Ctrl-Shift-9-Valid-Global-Shortcut") {

+ if (command == "MediaStop-non-global") {

chrome.test.notifyPass();

return;

}