chrome/test/data/extensions/api_test/keybinding/global_media_keys_1/manifest.json - Issue 64273008: [Windows] Finish global and non-global media keys support on Windows.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/api_test/keybinding/global_media_keys_1/manifest.json

Issue 64273008: [Windows] Finish global and non-global media keys support on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/views/extensions/extension_keybinding_registry_views.cc ('K') | « chrome/test/data/extensions/api_test/keybinding/global_media_keys_1/background.js ('k') | chrome/test/data/extensions/api_test/keybinding/non_global_media_keys_0/background.js » ('j') | chrome/test/data/extensions/api_test/keybinding/non_global_media_keys_0/manifest.json » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 {

	2 "name": "An extension to test global media keys command",

	3 "version": "1.0",

	4 "manifest_version": 2,

	5 "background": {

	6 "scripts": ["background.js"]

	7 },

	8 "commands": {

	9 "MediaNextTrack-global": {

	10 "suggested_key": {

	11 "default": "MediaNextTrack"

	12 },

	13 "global": true,

	14 "description": "Test passes if called."
	Finnur 2013/11/12 16:27:54 nit: "Description" before "global" (alphabetical o nit: "Description" before "global" (alphabetical order). Also, don't you want the stop event here too, or? zhchbin 2013/11/13 05:01:57 Done. Show quoted text On 2013/11/12 16:27:54, Finnur wrote: > nit: "Description" before "global" (alphabetical order). Also, don't you want > the stop event here too, or? Done.
	15 }

	16 }

	17 }

OLD	NEW