[Windows] Finish global and non-global media keys support on Windows.

chrome/browser/extensions/extension_commands_global_registry.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_commands_global_registry.h"
 
 #include "base/lazy_instance.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/api/commands/command_service.h"
 #include "chrome/browser/extensions/extension_keybinding_registry.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/global_shortcut_listener.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/extensions/extension.h"
 
 namespace extensions {
 
 ExtensionCommandsGlobalRegistry::ExtensionCommandsGlobalRegistry(
     Profile* profile)
     : ExtensionKeybindingRegistry(
           profile, ExtensionKeybindingRegistry::ALL_EXTENSIONS, NULL),
       profile_(profile) {
   Init();
 }
 
 ExtensionCommandsGlobalRegistry::~ExtensionCommandsGlobalRegistry() {
-  EventTargets::const_iterator iter;
-  for (iter = event_targets_.begin(); iter != event_targets_.end(); ++iter) {
+  EventTargets::const_iterator eit;
+  for (eit = event_targets_.begin(); eit != event_targets_.end(); ++eit) {
     GlobalShortcutListener::GetInstance()->UnregisterAccelerator(
-        iter->first, this);
+        eit->first, this);
+  }

[Finnur, 2013/11/12 16:27:54]

I'm not too keen on the iter -> eit/mit change here (and elsewhere).

Can you switch these two for loops to look like this instead? 

for (EventTargets::const_iterator iter = event_targets_.begin(); iter !=
event_targets_.end(); ++iter)

Then both can use iter as the name (iterator scoped within the for loop).

[zhchbin, 2013/11/13 05:01:57]

Done.

+
+  MediaKeysEventTargets::const_iterator mit;
+  for (mit = media_keys_event_targets_.begin();
+       mit != media_keys_event_targets_.end();
+       ++mit) {
+    GlobalShortcutListener::GetInstance()->UnregisterAccelerator(
+        mit->first, this);
   }
 }
 
 static base::LazyInstance<
     ProfileKeyedAPIFactory<ExtensionCommandsGlobalRegistry> >
 g_factory = LAZY_INSTANCE_INITIALIZER;
 
 // static
 ProfileKeyedAPIFactory<ExtensionCommandsGlobalRegistry>*
 ExtensionCommandsGlobalRegistry::GetFactoryInstance() {
@@ skipping 28 matching lines @@
 
   extensions::CommandMap::const_iterator iter = commands.begin();
   for (; iter != commands.end(); ++iter) {
     if (!command_name.empty() && (iter->second.command_name() != command_name))
       continue;
 
     VLOG(0) << "Adding global keybinding for " << extension->name().c_str()
             << " " << command_name.c_str()
             << " key: " << iter->second.accelerator().GetShortcutText();
 
-    event_targets_[iter->second.accelerator()] =
-        std::make_pair(extension->id(), iter->second.command_name());
+    if (extensions::CommandService::IsMediaKey(iter->second.accelerator())) {
+      std::pair<std::string, std::string> target =
+          std::make_pair(extension->id(), iter->second.command_name());
+      media_keys_event_targets_[iter->second.accelerator()].push_back(target);
+    } else {
+      event_targets_[iter->second.accelerator()] =
+          std::make_pair(extension->id(), iter->second.command_name());
+    }
 
     GlobalShortcutListener::GetInstance()->RegisterAccelerator(
       iter->second.accelerator(), this);
   }
 }
 
 void ExtensionCommandsGlobalRegistry::RemoveExtensionKeybindingImpl(
     const ui::Accelerator& accelerator,
     const std::string& command_name) {
   VLOG(0) << "Removing keybinding for " << command_name.c_str();
 
   GlobalShortcutListener::GetInstance()->UnregisterAccelerator(
       accelerator, this);
 }
 
 void ExtensionCommandsGlobalRegistry::OnKeyPressed(
     const ui::Accelerator& accelerator) {
-  EventTargets::iterator it = event_targets_.find(accelerator);
-  if (it == event_targets_.end()) {
-    NOTREACHED();  // Shouldn't get this event for something not registered.
-    return;
-  }
-
-  CommandExecuted(it->second.first, it->second.second);
+  ExtensionKeybindingRegistry::NotifyEventTargetsByAccelerator(accelerator);
 }
 
 }  // namespace extensions