[Windows] Finish global and non-global media keys support on Windows.

chrome/browser/extensions/api/commands/command_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_COMMANDS_COMMAND_SERVICE_H_
 #define CHROME_BROWSER_EXTENSIONS_API_COMMANDS_COMMAND_SERVICE_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 49 matching lines @@
   // Constructs a CommandService object for the given profile.
   explicit CommandService(Profile* profile);
   virtual ~CommandService();
 
   // ProfileKeyedAPI implementation.
   static ProfileKeyedAPIFactory<CommandService>* GetFactoryInstance();
 
   // Convenience method to get the CommandService for a profile.
   static CommandService* Get(Profile* profile);
 
+  // Return true if the specified accelerator is one of the following multimedia
+  // keys: Next Track key, Previous Track key, Stop Media key, Play/Pause Media
+  // key.

[Finnur, 2013/11/12 16:27:54]

You don't mention that e.g. a Ctrl+Next Track returns false...

[zhchbin, 2013/11/13 05:01:57]

Done.

+  static bool IsMediaKey(const ui::Accelerator& accelerator);
+
   // Gets the command (if any) for the browser action of an extension given
   // its |extension_id|. The function consults the master list to see if
   // the command is active. Returns false if the extension has no browser
   // action. Returns false if the command is not active and |type| requested
   // is ACTIVE_ONLY. |command| contains the command found and |active| (if not
   // NULL) contains whether |command| is active.
   bool GetBrowserActionCommand(const std::string& extension_id,
                                QueryType type,
                                extensions::Command* command,
                                bool* active);
@@ skipping 97 matching lines @@
   // is ignored. |user_pref| is the PrefService used to record the new
   // keybinding assignment.
   void AssignInitialKeybindings(const extensions::Extension* extension);
 
   bool GetExtensionActionCommand(const std::string& extension_id,
                                  QueryType query_type,
                                  extensions::Command* command,
                                  bool* active,
                                  ExtensionActionType action_type);
 
+  // A counter that used to append to the key of keybindings map when adding

[Finnur, 2013/11/12 16:27:54]

s/that/that is/, but see below.

[zhchbin, 2013/11/13 05:01:57]

Done. Removed.

+  // media keys preferences, so that we can make sure the key can be unique, and
+  // the same media key can be assigned to multi commands.
+  int media_keys_command_counter_;

[Finnur, 2013/11/12 16:27:54]

I don't think this is going to work. For example, when you restart the browser,
you'll reset the number and start overwriting your previous bindings. Also,
think of sync -- you might be setting media keybindings on two different
computers and both might be going for the same counter value.

Can't we make the key unique by using extension id + command name instead?

[zhchbin, 2013/11/13 05:01:57]

Done. Now using extension id for make the key quique. I make a stupid mistake
here. Sigh..

[Finnur, 2013/11/13 10:22:24]

Ah, don't beat yourself too hard. :)

+
   // The content notification registrar for listening to extension events.
   content::NotificationRegistrar registrar_;
 
   // A weak pointer to the profile we are associated with. Not owned by us.
   Profile* profile_;
 
   DISALLOW_COPY_AND_ASSIGN(CommandService);
 };
 
 template <>
 void ProfileKeyedAPIFactory<CommandService>::DeclareFactoryDependencies();
 
 }  //  namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_COMMANDS_COMMAND_SERVICE_H_