OLD | NEW |
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "chrome/browser/ui/views/extensions/extension_keybinding_registry_views
.h" | 5 #include "chrome/browser/ui/views/extensions/extension_keybinding_registry_views
.h" |
6 | 6 |
7 #include "chrome/browser/extensions/api/commands/command_service.h" | 7 #include "chrome/browser/extensions/api/commands/command_service.h" |
8 #include "chrome/browser/extensions/extension_keybinding_registry.h" | 8 #include "chrome/browser/extensions/extension_keybinding_registry.h" |
9 #include "chrome/browser/extensions/extension_service.h" | 9 #include "chrome/browser/extensions/extension_service.h" |
10 #include "chrome/browser/profiles/profile.h" | 10 #include "chrome/browser/profiles/profile.h" |
(...skipping 11 matching lines...) Expand all Loading... |
22 views::FocusManager* focus_manager, | 22 views::FocusManager* focus_manager, |
23 ExtensionFilter extension_filter, | 23 ExtensionFilter extension_filter, |
24 Delegate* delegate) | 24 Delegate* delegate) |
25 : ExtensionKeybindingRegistry(profile, extension_filter, delegate), | 25 : ExtensionKeybindingRegistry(profile, extension_filter, delegate), |
26 profile_(profile), | 26 profile_(profile), |
27 focus_manager_(focus_manager) { | 27 focus_manager_(focus_manager) { |
28 Init(); | 28 Init(); |
29 } | 29 } |
30 | 30 |
31 ExtensionKeybindingRegistryViews::~ExtensionKeybindingRegistryViews() { | 31 ExtensionKeybindingRegistryViews::~ExtensionKeybindingRegistryViews() { |
32 EventTargets::const_iterator iter; | 32 for (EventTargets::const_iterator iter = event_targets_.begin(); |
33 for (iter = event_targets_.begin(); iter != event_targets_.end(); ++iter) | 33 iter != event_targets_.end(); ++iter) |
34 focus_manager_->UnregisterAccelerator(iter->first, this); | 34 focus_manager_->UnregisterAccelerator(iter->first, this); |
35 } | 35 } |
36 | 36 |
37 void ExtensionKeybindingRegistryViews::AddExtensionKeybinding( | 37 void ExtensionKeybindingRegistryViews::AddExtensionKeybinding( |
38 const extensions::Extension* extension, | 38 const extensions::Extension* extension, |
39 const std::string& command_name) { | 39 const std::string& command_name) { |
40 // This object only handles named commands, not browser/page actions. | 40 // This object only handles named commands, not browser/page actions. |
41 if (ShouldIgnoreCommand(command_name)) | 41 if (ShouldIgnoreCommand(command_name)) |
42 return; | 42 return; |
43 | 43 |
44 extensions::CommandService* command_service = | 44 extensions::CommandService* command_service = |
45 extensions::CommandService::Get(profile_); | 45 extensions::CommandService::Get(profile_); |
46 // Add all the active keybindings (except page actions and browser actions, | 46 // Add all the active keybindings (except page actions and browser actions, |
47 // which are handled elsewhere). | 47 // which are handled elsewhere). |
48 extensions::CommandMap commands; | 48 extensions::CommandMap commands; |
49 if (!command_service->GetNamedCommands( | 49 if (!command_service->GetNamedCommands( |
50 extension->id(), | 50 extension->id(), |
51 extensions::CommandService::ACTIVE_ONLY, | 51 extensions::CommandService::ACTIVE_ONLY, |
52 extensions::CommandService::REGULAR, | 52 extensions::CommandService::REGULAR, |
53 &commands)) | 53 &commands)) |
54 return; | 54 return; |
55 extensions::CommandMap::const_iterator iter = commands.begin(); | 55 extensions::CommandMap::const_iterator iter = commands.begin(); |
56 for (; iter != commands.end(); ++iter) { | 56 for (; iter != commands.end(); ++iter) { |
57 if (!command_name.empty() && (iter->second.command_name() != command_name)) | 57 if (!command_name.empty() && (iter->second.command_name() != command_name)) |
58 continue; | 58 continue; |
59 | 59 |
60 event_targets_[iter->second.accelerator()] = | 60 event_targets_[iter->second.accelerator()].push_back( |
61 std::make_pair(extension->id(), iter->second.command_name()); | 61 std::make_pair(extension->id(), iter->second.command_name())); |
| 62 // Shortcuts except media keys have only one target in the list. See comment |
| 63 // about |event_targets_|. |
| 64 if (!extensions::CommandService::IsMediaKey(iter->second.accelerator())) |
| 65 DCHECK(event_targets_[iter->second.accelerator()].size() == 1); |
| 66 if (event_targets_[iter->second.accelerator()].size() > 1) |
| 67 continue; // It is already registered with the focus manager. |
| 68 |
62 focus_manager_->RegisterAccelerator( | 69 focus_manager_->RegisterAccelerator( |
63 iter->second.accelerator(), | 70 iter->second.accelerator(), |
64 ui::AcceleratorManager::kHighPriority, this); | 71 ui::AcceleratorManager::kHighPriority, this); |
65 } | 72 } |
66 } | 73 } |
67 | 74 |
68 void ExtensionKeybindingRegistryViews::RemoveExtensionKeybindingImpl( | 75 void ExtensionKeybindingRegistryViews::RemoveExtensionKeybindingImpl( |
69 const ui::Accelerator& accelerator, | 76 const ui::Accelerator& accelerator, |
70 const std::string& command_name) { | 77 const std::string& command_name) { |
71 focus_manager_->UnregisterAccelerator(accelerator, this); | 78 focus_manager_->UnregisterAccelerator(accelerator, this); |
72 } | 79 } |
73 | 80 |
74 bool ExtensionKeybindingRegistryViews::AcceleratorPressed( | 81 bool ExtensionKeybindingRegistryViews::AcceleratorPressed( |
75 const ui::Accelerator& accelerator) { | 82 const ui::Accelerator& accelerator) { |
76 EventTargets::iterator it = event_targets_.find(accelerator); | 83 return ExtensionKeybindingRegistry::NotifyEventTargets(accelerator); |
77 if (it == event_targets_.end()) { | |
78 NOTREACHED(); // Shouldn't get this event for something not registered. | |
79 return false; | |
80 } | |
81 | |
82 CommandExecuted(it->second.first, it->second.second); | |
83 | |
84 return true; | |
85 } | 84 } |
86 | 85 |
87 bool ExtensionKeybindingRegistryViews::CanHandleAccelerators() const { | 86 bool ExtensionKeybindingRegistryViews::CanHandleAccelerators() const { |
88 return true; | 87 return true; |
89 } | 88 } |
OLD | NEW |