Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 64273006: Move ExtensionFunction to the extensions component. (Closed)

Created:
7 years, 1 month ago by benwells
Modified:
7 years, 1 month ago
Reviewers:
miket_OOO, sky
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yukishiino+watch_chromium.org, Lei Zhang, Greg Billock, nona+watch_chromium.org, oshima+watch_chromium.org, tommycli, vandebo (ex-Chrome), chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org, Yoyo Zhou, James Cook, Daniel Erat, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Move ExtensionFunction to the extensions component. TBR=sky@chromium.org BUG=162530 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234673

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -727 lines) Patch
M chrome/browser/chromeos/extensions/info_private_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/input_method_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/media_player_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_function_base.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/alarms/alarm_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/app_runtime/app_runtime_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/cast_channel/cast_channel_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/command_line_private/command_line_private_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/developer_private/entry_picker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/dns/dns_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/identity_private/identity_private_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/idltest/idltest_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/input/input.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/log_private/log_private_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/metrics_private/metrics_private_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/music_manager_private/music_manager_private_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/notifications/notifications_api.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/power/power_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/serial/serial_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/socket/socket_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/streams_private/streams_private_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/system_cpu/system_cpu_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/system_display/system_display_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/system_indicator/system_indicator_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/system_memory/system_memory_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/system_storage/system_storage_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/chrome_extension_function.h View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/extensions/extension_function.h View 1 chunk +0 lines, -435 lines 0 comments Download
D chrome/browser/extensions/extension_function.cc View 1 chunk +0 lines, -243 lines 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_function_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/pepper/pepper_extensions_common_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/speech/extension_api/tts_engine_extension_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/speech/tts_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/browser/DEPS View 1 chunk +3 lines, -1 line 0 comments Download
A + extensions/browser/extension_function.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/browser/extension_function.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/quota_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/quota_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
benwells
7 years, 1 month ago (2013-11-12 10:05:12 UTC) #1
miket_OOO
lgtm
7 years, 1 month ago (2013-11-12 19:05:17 UTC) #2
benwells
+tbr sky for refactoring fallout
7 years, 1 month ago (2013-11-12 21:32:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/64273006/1
7 years, 1 month ago (2013-11-12 21:37:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/64273006/1
7 years, 1 month ago (2013-11-12 23:37:24 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-13 00:18:47 UTC) #6
Message was sent while issue was closed. 
Change committed as 234673

Powered by Google App Engine
This is Rietveld 408576698