Add DumpAccessibilityTree tests for modal dialogs.

Add DumpAccessibilityTree tests for modal dialogs.

This tests the Blink-side change:
https://codereview.chromium.org/70213002/

Some DumpAccessibilityTree tests crash on Android
(http://crbug.com/314376), this CL removes Android
expectations for those tests so we know to rebaseline
when the bug is fixed.

BUG=304779
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235091

[falken, 2013-11-07 13:34:41]

Do you know if it's guaranteed that the test runner will wait for the JavaScript
to terminate (and the browser side to process AX notifications and finish
updating the tree), or could these be flakey?

I'll add Android and Win expectations from the trybots. It might be necessary to
 to change content_browsertests on the bots to use
--experimental-web-platform-features.

[dmazzoni, 2013-11-07 16:23:50]

On 2013/11/07 13:34:41, falken wrote:
> Do you know if it's guaranteed that the test runner will wait for the
JavaScript
> to terminate (and the browser side to process AX notifications and finish
> updating the tree), or could these be flakey?

I think it might be flaky. We should add a mechanism for this.

How about something like this: we set the title of the document to "pending",
and the DumpAccessibilityTree runner will keep waiting on notifications until
after that title disappears. Then you can do whatever you want in JavaScript and
set the title when it's done.

> I'll add Android and Win expectations from the trybots. It might be necessary
to
>  to change content_browsertests on the bots to use
> --experimental-web-platform-features.

Can you do it by adding a line of C++ code to
dump_accessibility_tree_browsertest.cc rather than changing the bots? I'd prefer
if the tests pass if a random engineer tries to run them locally.

[dmazzoni, 2013-11-07 16:27:33]

lgtm

Actually after thinking about this some more, I don't think this should be
flaky. Inline scripts will run before the document finishes loading. It's only
an issue if we have anything asynchronous, but you don't.

https://codereview.chromium.org/64273003/diff/80001/content/browser/accessibi...
File content/browser/accessibility/dump_accessibility_tree_browsertest.cc
(right):

https://codereview.chromium.org/64273003/diff/80001/content/browser/accessibi...
content/browser/accessibility/dump_accessibility_tree_browsertest.cc:127:
CommandLine::ForCurrentProcess()->AppendSwitch(
Nevermind, looks like you already did this. That's what I had in mind. That
shouldn't require any changes on the bots, right?

[falken, 2013-11-08 05:03:56]

I updated with windows expectations, but the Android bot is crashing
(https://code.google.com/p/chromium/issues/detail?id=314376)

I'll see if I can get a local run on Android, or else just commit and add
expectations when the bot is back.

https://codereview.chromium.org/64273003/diff/80001/content/browser/accessibi...
File content/browser/accessibility/dump_accessibility_tree_browsertest.cc
(right):

https://codereview.chromium.org/64273003/diff/80001/content/browser/accessibi...
content/browser/accessibility/dump_accessibility_tree_browsertest.cc:127:
CommandLine::ForCurrentProcess()->AppendSwitch(
On 2013/11/07 16:27:34, Dominic Mazzoni wrote:
> Nevermind, looks like you already did this. That's what I had in mind. That
> shouldn't require any changes on the bots, right?

Yes, I realized I could do it this way after sending my first comment. Sorry for
not following up.

[falken, 2013-11-12 12:34:50]

Dominic, could you take another look please?

I haven't committed yet as the earlier Blink change got reverted. Along with the
new change, I've added some tests for <dialog> in <iframe>, which I realized
would be good since the AX cache is owned by the top document.

As before, I'm waiting on Android/Win trybots for the full expectations set.

[dmazzoni, 2013-11-12 21:24:01]

Still lgtm

[commit-bot: I haz the power, 2013-11-14 05:03:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/falken@chromium.org/64273003/470001

[commit-bot: I haz the power, 2013-11-14 06:37:45]

Retried try job too often on linux_rel for step(s) nacl_integration
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-11-14 06:46:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/falken@chromium.org/64273003/470001

[commit-bot: I haz the power, 2013-11-14 07:44:30]

Change committed as 235091